From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754652AbeARAXc (ORCPT ); Wed, 17 Jan 2018 19:23:32 -0500 Received: from mail-ve1eur01on0097.outbound.protection.outlook.com ([104.47.1.97]:58003 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753688AbeARAX3 (ORCPT ); Wed, 17 Jan 2018 19:23:29 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=avagin@virtuozzo.com; Date: Wed, 17 Jan 2018 16:23:09 -0800 From: Andrei Vagin To: Andrew Lunn Cc: Florian Fainelli , netdev@vger.kernel.org, edumazet@google.com, cphealy@gmail.com, David Decotigny , "David S. Miller" , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Daniel Borkmann , Nikolay Aleksandrov , Alexei Starovoitov , Roopa Prabhu , Mahesh Bandewar , Vlad Yasevich , Jakub Kicinski , Jonas Bonn , stephen hemminger , Hans Liljestrand , "Reshetova, Elena" , Kirill Tkhai , Andrey Vagin , Florian Westphal , David Ahern , Xin Long , Matthias Schiffer , Jiri Benc , open list Subject: Re: [PATCH net-next] net: core: Expose number of link up/down transitions Message-ID: <20180118002308.GA21605@outlook.office365.com> References: <20180117230704.21949-1-f.fainelli@gmail.com> <20180117234941.GA19561@outlook.office365.com> <20180118000652.GD32299@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20180118000652.GD32299@lunn.ch> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [65.152.152.74] X-ClientProxiedBy: HE1PR0101CA0004.eurprd01.prod.exchangelabs.com (2603:10a6:3:77::14) To VI1PR08MB0751.eurprd08.prod.outlook.com (2a01:111:e400:5a04::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f5c1d41e-6ae6-4d9a-9787-08d55e09b0e1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:VI1PR08MB0751; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0751;3:fMbjWXonBilnldEelWaxHxYNwY6tjP2OLULLwYKoDt1w0qpJXvn5gIWXC4ICodr8SjgAPOTwOg998JCSaMPdEAdo584j54KpoOF0/rWUvGddByTdqxlOUxK9qBE1PFfBCY2mbYmqXBUKcOKFtLcek47tk4iWfu4HTr2WojfQl2pUDhzZiymY+U1rMD1OWKXpSX5Hjw5fZNfzLlSJuEoqR1lx2GZ2+j3YKGo7Nb0btzPLSQxmZkeGTCeAxFcERcEq;25:evwJ1cSS5nbU/flX97T7aPPsSEi1OhT/li3X+4+q/iiF5l5M1zJ6goqWtjB/yhObGjFqm6s5sSwjiJti73WuE3rv5LInVjMlSSKHR7pxGvzCWh9ntpptjGMKbV73Ddek20FSgD3yRSEbIkFkDYxBYk3Jnf8cMhWqEWaO9gzSe9j4BITZz5oZMjSg3TWcbWMzPTqeDlYFclAuqYz7jcfr3h/7QwhDuQTSDwG+Zlv15MP6txtFelbAe8A/YcyLyUvgRNXlSfbzLAoNQvpYKOQsidiQDspros+Mh0/ak/EsbC/hD308+ZE0uoyx5n55yvcznV8txtFNUtOqIWKxNfa1mQ==;31:j6hzOWqUeiZtCKulUWiaSo73EPg1I+Baq499GOYXep7T5NzRPkfh3/jS2dG1H1LOMDfHL53H16ZD7l/wy+1W8D5Ews+6V3W71+72PkcazViqTb+dJgb7lxg0EuBHvoF4RNVHx02ugZHGyobGl8tYuURfaU2OonCAbsymz/ryNgwo8RrDOulEWR2e3vke4Nxk71owYC1JXnUdtNai8lKU868US/deLclVfctAJ66cCLI= X-MS-TrafficTypeDiagnostic: VI1PR08MB0751: X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0751;20:jEp4OA9U4+a8TxDsoU4wg9yPoDWsdKXen6ns29SEvcjoBCWhjsYhZAB3hYYmF5lf2oBK4yEPM/Di6sxConrZ45RmC0Bz/kM8/TJFpe+18caea/mGaZGpMJmglNwC6hO/S6G6pWrar6139C1I0n27U7qQVA8LhYxi79ZjQlSsOuTDIiXb/5Zx5+mXDz08rfiERqu/kSAA5ng3Z7p69+U7eumYgf0ekvN4R4qQGHQCQojx9p5Dx0zitiiljfa/gnPaQbw6NVDCBacrDutAnLyKPyjtIMpW7rGvTLZ+nLcWFnhSqCMi/YB6Gap+kBJlTa7DxjPFGAhDp9Ov7k0IVzH0xd2icbzU3NwkwyHPdGWBZv0DlRpmICo4+oPz4l7+qdEv6bZGrBkr7Mag+K5ffeE5Cf4m8MFXX6VfNHufiPMyIT8=;4:zv8SqjrH8RODh4h7Y4z3OCF1URwcQ51G4prY3Oh2uXkXhL7aDebcWI+L3gLBMCWZ6vazOgLyhvlLGh+vOvdXDwf6OJq7zL/JOBPAAaew8c22zsaxzaeMhZBkTF6tePXvadr/eh+whR8PmjSiy+YaTRClYbCE6/4jfnMTrXqlSpoEE00AhB165vSHR5DcCDT47iYcaOQKaTkS9stLYv6DlxaB8n4sVa/wz5sq3L3KgK/HHjhIxHn5GZHjj7Qa9fObUwXGhlFE74RKbX+7swmerA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(2400053)(944501161)(10201501046)(93006095)(93001095)(3002001)(6041268)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011);SRVR:VI1PR08MB0751;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR08MB0751; X-Forefront-PRVS: 05568D1FF7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(366004)(376002)(346002)(396003)(39850400004)(39380400002)(189003)(199004)(50466002)(53416004)(106356001)(54906003)(97736004)(16526018)(16586007)(83506002)(316002)(58126008)(3846002)(47776003)(478600001)(229853002)(86362001)(53936002)(1076002)(6116002)(66066001)(7736002)(2906002)(305945005)(7416002)(55016002)(23686003)(6506007)(26005)(386003)(4326008)(25786009)(81166006)(8936002)(6246003)(39060400002)(81156014)(8676002)(68736007)(69596002)(52116002)(7696005)(9686003)(76176011)(33656002)(105586002)(6666003)(5660300001)(6916009)(2950100002)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR08MB0751;H:outlook.office365.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?koi8-r?Q?1;VI1PR08MB0751;23:2+lVb+dKCKbzGcgDBA2itS3CjEtFbqvN/rIbZysEndj?= =?koi8-r?Q?Cyg+9+t+Wd6x0fcKEkmM21XfkkS3xjaGocG16K8YFOC+IXHCEznxrhajd+n5IF?= =?koi8-r?Q?z12MtfML9RRi9VfBpMtJqALHl5OoeGiw7iAOssEM10+vglGa+gkPO+TCl5kaw7?= =?koi8-r?Q?eREbDSNrXYX9jMt16XEzSaDRSbFRoP/8iGIrMHLk9IL3WXqTigbwLVHJ/ZCzEa?= =?koi8-r?Q?7iePZFmZS090TwQkQ2lEvEq/aYDUI+Ixra40+N1ZxlOShf7luBJC6S37bCaNTQ?= =?koi8-r?Q?FB2GIWrlr1kipMGr5I9CxEdT5wtcUKgXOduZEPKw49k74xDlxkBtGYWmnKR5ov?= =?koi8-r?Q?NBiWluyA8ZgQK7DVnKWXL/etJUcehcstxeLaD+OIPNvtfXsxoVzpUmtqOEOh2N?= =?koi8-r?Q?Wcu6t4DQdTA+YdCF5VoU6RnCCg6mDJLGo4Ho/MwkRaN/5VS6Ytl8+eo75Bxv3Q?= =?koi8-r?Q?xQa+jkKChWCjg2SF31zuwMJ/8f+KaYRQSHM8PL8GtLc/8q925NAkoSbjYxjUQ3?= =?koi8-r?Q?A0xBEJL6fTwX3WdzZ3Wk5vSIcXu30rZNAmo+S7JsNm5JTerx/QrNQxoXRmbWgo?= =?koi8-r?Q?OuuLWNeEjsOa4TbYVORkP2YYVIyUMsCbPiiYQ+a6lGA3iA+5d77yKxEMFGKpt3?= =?koi8-r?Q?cWoZu63lyw2DpOK44psMFrZE94UqNHxibHcaXzzIx+84oS8LOrgJpxwPht6kvz?= =?koi8-r?Q?cmkWmW3dOHgjLLhHYcMXJ8hfeGrdJ3QmE0NNi5faOVUrE7aMCybAN3qluvw5DC?= =?koi8-r?Q?9K2KO4x+Ph500+mn4712yTLedxUnn8T/Pr+q7LBy6nJ5UgajThW9Fd6sqevI7p?= =?koi8-r?Q?A6ocwja7j80sTTjVKcTn8o/2JYvQIPv6bjoQF3jFhBZYSZ/ZqklJyWdQqzyzHt?= =?koi8-r?Q?/xIAwlqjyYxmj1geKE93NouWD3oBHc2GetvfoQOiJmHge5676ji6UBIqIpreeZ?= =?koi8-r?Q?hQnNZP+cqjPt+p/0qw+XdZnEQE/lrwTjfCFV7NXtscWLr9lyLzHt2aZr8CFHJ5?= =?koi8-r?Q?r0rhchjor8lIeoPxxJVdou/frhUVdk27K+5XCWDqoFCYyBIdLbkPWFuI3uHLtj?= =?koi8-r?Q?fwtuNkmxQy0XyxMEtua21aPgALA2+IzlxvcSywEDn0ARSkOh4KBl6JZspTt0Ly?= =?koi8-r?Q?NxKkBEUeLKXwhFqTlMHyFl5HbaZMOHz7L7dVtjYscrs3ZyJBphpxru5FsFHHmL?= =?koi8-r?Q?AuHUtQfwa8tF9sJXDPb6d/zV8gGNQjeL3qiXsjkF0bYNq0eq1brxUlhPJq8Twr?= =?koi8-r?Q?GG/X0RfoPwh/TrI6VpQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0751;6:yT6U5+ipWUgPqpF+zEDBgQXr6fzpg5mBkuGncJcS/NM06Q2RravGJBybzHoFEsqgBoAyKWQBudZnpYPwm/lG84RRMYC7u6ZqFdrBr+7l3yD2eXVnXLoI8MOxrkojYmKK6RIHI1vRrt0hA44VQBrNAQYttoK00b+ndFq9nPNQxLzpZYMfAP/ziZjdSKUfsr0jnpx0cqmjQS5JiZhj95k6JEICnypIB3WToNHGJL/aUlKEalk8ZVZrqy1+W188ZowfDpeUbqjdeV5FxHXxz7RzLLCJa/Ey+suDKoviuitSXUa74r3XBoBU+5aX6yXVSB3QLwKEnXs/M9hvdrh4Q8uuzJ3+SowdGIHZELjvw4HGKZE=;5:vHJrrXaDOFDIT6hZEp69WDxzotzKa4vD4l1mDVHLITfF169EjU4e8RMK3XQhojMu4Rf4Dv988lYi1mBj1HZphlx+/UfuOkAdelIpHEnjBEP4i3gEyVgOGpW8ydyjxREugRJ6zdHhLW/oMskLDhUQtebN3H6iFNsutJUJlYomU9Q=;24:pp3lRg1JsIK52Ks9VA76ltgrUWdK+Ds9/h1V15v2zencfKJePJXp0SLazDCwj6riaBNWQTFlNC2ZoMlFMJlrmQ0j+Ci76OhJ80FnoS5oS10=;7:gYtGwDXAK/rmuAK4W75RYY28mqoAYci7OLD2G9ct/MAu1vwJQN4t+04y1bSYVsmLc27wLXkayMyk7F31+3XpiyJQlD+vWx+mmtr3Vhu8+IU3IVdrixfVxhg1OWzQreP9Mj7i9K6dad6P8g04kAP+zzHl9SsxGQ/KXVjz0hSJDoxYLP4GWbI2bfd9GSKw5o4rTyyO1bBY5Kb6o/lWEPK9gqLXPUxjX9fRQwSuslgXvpVKuGRRf5tqGapV9BYX6CR/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB0751;20:2CyX04D2RktQLRGZlW5mR7XGx6EVFk9pRGpGdiP8rgEUt+vanzzDXQC7bs6reS6deLICsOZ4z6+RkKaWCEMegkdluJ1Hn+3VcPsl0x7gQOxw7SSp00TNwra2CUI6x7Kki8LYucWG64b0xjUi/tUoC5x1H+HzsCgrZ7XaXmv6ZdU= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2018 00:23:16.5113 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5c1d41e-6ae6-4d9a-9787-08d55e09b0e1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB0751 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 18, 2018 at 01:06:52AM +0100, Andrew Lunn wrote: > > What is the idea to have two separate counters? Can a delta between them > > be a bigger than 1? > > Yes, it can. > > These counters are incremented in netif_carrier_on() / > netif_carrier_off(). They are not always called in pairs and they can > be called multiple times for the same event. The phylib will call them > when it notices the PHY saying the link is down/up, and the MAC driver > sometimes also calls them. We check the __LINK_STATE_NOCARRIER bit before changing these counters, so if we call netif_carrier_on() twice, the counter will be incrimented only by one, will it not? void netif_carrier_on(struct net_device *dev) if (test_and_clear_bit(__LINK_STATE_NOCARRIER, &dev->state)) { atomic_inc(&dev->carrier_changes); ... void netif_carrier_off(struct net_device *dev) if (!test_and_set_bit(__LINK_STATE_NOCARRIER, &dev->state)) { atomic_inc(&dev->carrier_changes); > > Andrew