From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932082AbeARAlq (ORCPT ); Wed, 17 Jan 2018 19:41:46 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:43011 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753023AbeARAlp (ORCPT ); Wed, 17 Jan 2018 19:41:45 -0500 Date: Wed, 17 Jan 2018 16:41:43 -0800 From: Matthew Wilcox To: "Paul E. McKenney" Cc: Josh Triplett , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rcu: Use wrapper for lockdep asserts Message-ID: <20180118004143.GA376@bombadil.infradead.org> References: <20180117142430.GB10398@bombadil.infradead.org> <20180117232913.GY9671@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180117232913.GY9671@linux.vnet.ibm.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 17, 2018 at 03:29:13PM -0800, Paul E. McKenney wrote: > On Wed, Jan 17, 2018 at 06:24:30AM -0800, Matthew Wilcox wrote: > > > > From: Matthew Wilcox > > > > Commits c0b334c5bfa9 and ea9b0c8a26a2 introduced new sparse warnings > > by accessing rcu_node->lock directly and ignoring the __private > > marker. Introduce a new wrapper and use it. Also fix a similar problem > > in srcutree.c introduced by a3883df3935e. > > > > Signed-off-by: Matthew Wilcox > > Good catch! Applied for review and testing. > > For some reason, I was expecting 0day to catch this sort of thing... Funny you should say, it was 0day which pointed it out to me! I changed lockdep to take a const struct lockdep_map *lock instead of a plain struct lockdep_map *lock and I got a whinge from 0day that I'd changed some of the warnings, so I looked into it in case it was my fault.