mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers3@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Pavel Machek <pavel@ucw.cz>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run
Date: Wed, 17 Jan 2018 17:46:45 -0800	[thread overview]
Message-ID: <20180118014645.66zlrz3bma6wc4xl@gmail.com> (raw)
In-Reply-To: <1516238297.3045.62.camel@perches.com>

On Wed, Jan 17, 2018 at 05:18:17PM -0800, Joe Perches wrote:
> On Wed, 2018-01-17 at 20:09 -0500, Theodore Ts'o wrote:
> > get_maintainer.pl, which is often not accurate
> 
> Examples please.
> 

Well, the primary problem is that place the crash occurs is not necessarily
responsible for the bug.  But, syzbot actually does have a file blacklist for
exactly that reason; see
https://github.com/google/syzkaller/blob/master/pkg/report/linux.go#L56

It definitely needs further improvement (and anyone is welcome to contribute),
though it will never be perfect.  

There is also a KASAN change by Dmitry queued up for 4.16 that will allow KASAN
to detect invalid frees.  That would have detected the bug in crypto/pcrypt.c
that was causing corruption in the kmalloc-1024 slab cache, and was causing
crashes in all sorts of random kernel code, resulting many bug reports.  So,
detecting bugs early before they corrupt all sorts of random kernel data
structures helps a lot too.

And yes, get_maintainer.pl sometimes isn't accurate even if the offending code
is correctly identified.  That's more of a community problem, e.g. people
sometimes don't bother to remove themselves from MAINTAINERS when they quit
maintaining, and sometimes people don't feel responsible enough for a file to
add themselves to MAINTAINERS, even when in practice they are actually taking
most of the patches to it through their tree.

Eric

  reply	other threads:[~2018-01-18  1:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-13  1:58 syzbot
2018-01-14  0:16 ` Daniel Borkmann
2018-01-14 16:03   ` David Miller
2018-01-17  9:32 ` dangers of bots on the mailing lists was " Pavel Machek
2018-01-17  9:35   ` syzbot
2018-01-17  9:35   ` syzbot
2018-01-17  9:45   ` dangers of bots on the mailing lists was " Dmitry Vyukov
2018-01-17  9:49     ` Pavel Machek
2018-01-17 10:11     ` Henrique de Moraes Holschuh
2018-01-18 10:57       ` Dmitry Vyukov
2018-01-18 13:41         ` Henrique de Moraes Holschuh
2018-01-17  9:48   ` Dmitry Vyukov
2018-01-17  9:52     ` Pavel Machek
2018-01-17 10:03       ` Florian Westphal
2018-01-17  9:49   ` Daniel Borkmann
2018-01-17 11:09     ` Dmitry Vyukov
2018-01-17 20:47       ` Theodore Ts'o
2018-01-18  0:21         ` Alexei Starovoitov
2018-01-18  1:09           ` Theodore Ts'o
2018-01-18  1:18             ` Joe Perches
2018-01-18  1:46               ` Eric Biggers [this message]
2018-01-18  2:35                 ` Joe Perches
2018-01-18 13:01             ` Dmitry Vyukov
2018-01-18 13:06               ` Dmitry Vyukov
2018-01-18 14:05               ` Greg Kroah-Hartman
2018-01-22 13:31                 ` Dmitry Vyukov
2018-01-18 14:10               ` Guenter Roeck
2018-01-22  8:08                 ` Dmitry Vyukov
2018-01-18 13:10       ` Dmitry Vyukov
2018-01-18 14:46         ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180118014645.66zlrz3bma6wc4xl@gmail.com \
    --to=ebiggers3@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=dvyukov@google.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®