From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754725AbeARHl0 (ORCPT ); Thu, 18 Jan 2018 02:41:26 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:37948 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753390AbeARHlZ (ORCPT ); Thu, 18 Jan 2018 02:41:25 -0500 X-Google-Smtp-Source: ACJfBotG2+yNHPdn8gIP71Wz1aW2F4B2VUI/vJEN2HCHNbqmy7DMNjYot3hyrJcaw2KENBpUi/Ct1w== Date: Thu, 18 Jan 2018 16:41:20 +0900 From: Benjamin Poirier To: Jeff Kirsher Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] e1000e: Remove Other from EIAC. Message-ID: <20180118074120.j7qbmapusiypsvsq@f1.synalogic.ca> References: <20180118065054.29844-1-bpoirier@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180118065054.29844-1-bpoirier@suse.com> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/01/18 15:50, Benjamin Poirier wrote: > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver > overrun interrupt bursts", v4.15-rc1). Some tracing shows that after > e1000e_trigger_lsc() is called, ICR reads out as 0x0 in e1000_msix_other() > on emulated e1000e devices. In comparison, on real e1000e 82574 hardware, > icr=0x80000004 (_INT_ASSERTED | _OTHER) in the same situation. (_INT_ASSERTED | _LSC) > > Some experimentation showed that this flaw in vmware e1000e emulation can > be worked around by not setting Other in EIAC. This is how it was before > 16ecba59bc33 ("e1000e: Do not read ICR in Other interrupt", v4.5-rc1). > > Fixes: 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts") > Signed-off-by: Benjamin Poirier