From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750946AbeARI1T (ORCPT ); Thu, 18 Jan 2018 03:27:19 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:46081 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbeARI1Q (ORCPT ); Thu, 18 Jan 2018 03:27:16 -0500 X-Google-Smtp-Source: ACJfBosr4zsMx9PK6OTeRvfiwhSzpwYtT5eFFBRB4MOSCDMM6fR5eenrd8vk6Xje7WJzeTWiY6GSxQ== Date: Thu, 18 Jan 2018 08:27:13 +0000 From: Lee Jones To: Masahiro Yamada Cc: linux-mmc@vger.kernel.org, Wolfram Sang , Ulf Magnusson , Geert Uytterhoeven , Simon Horman , Yoshihiro Shimoda , linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Ulf Hansson Subject: Re: [PATCH v3 10/16] mmc: tmio: remove TMIO_MMC_WRPROTECT_DISABLE Message-ID: <20180118082713.jdc4u4shabx2qyge@dell> References: <1516206496-16612-1-git-send-email-yamada.masahiro@socionext.com> <1516206496-16612-11-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1516206496-16612-11-git-send-email-yamada.masahiro@socionext.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Jan 2018, Masahiro Yamada wrote: > The use of this flag has been replaced with MMC_CAP2_NO_WRITE_PROTECT. > No platform defines this flag any more. Remove. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v3: > - newly added > > Changes in v2: None > > drivers/mmc/host/tmio_mmc_core.c | 5 ++--- > include/linux/mfd/tmio.h | 1 - > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c > index bdbff2d..7ad3433c 100644 > --- a/drivers/mmc/host/tmio_mmc_core.c > +++ b/drivers/mmc/host/tmio_mmc_core.c > @@ -1075,10 +1075,9 @@ static void tmio_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > static int tmio_mmc_get_ro(struct mmc_host *mmc) > { > struct tmio_mmc_host *host = mmc_priv(mmc); > - struct tmio_mmc_data *pdata = host->pdata; > > - return !((pdata->flags & TMIO_MMC_WRPROTECT_DISABLE) || > - (sd_ctrl_read16_and_16_as_32(host, CTL_STATUS) & TMIO_STAT_WRPROTECT)); > + return !(sd_ctrl_read16_and_16_as_32(host, CTL_STATUS) & > + TMIO_STAT_WRPROTECT); > } > > static int tmio_multi_io_quirk(struct mmc_card *card, > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h > index 396a103c..91f9221 100644 > --- a/include/linux/mfd/tmio.h > +++ b/include/linux/mfd/tmio.h > @@ -36,7 +36,6 @@ > } while (0) > > /* tmio MMC platform flags */ > -#define TMIO_MMC_WRPROTECT_DISABLE BIT(0) If it is truly not in use after this set: Acked-by: Lee Jones -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog