From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755955AbeARLCi (ORCPT ); Thu, 18 Jan 2018 06:02:38 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:37255 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754656AbeARLCf (ORCPT ); Thu, 18 Jan 2018 06:02:35 -0500 X-Google-Smtp-Source: ACJfBounRPF8oQiXZBctdXXUmJtUfJ2cYWYzL/X2ymkjYHs1/HDv2PQu/B6ErPxfCRo/Vo6Czfxoig== Date: Thu, 18 Jan 2018 16:32:26 +0530 From: Meghana Madhyastha To: Daniel Thompson , Lee Jones , Jingoo Han , Thierry Reding , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Tomi Valkeinen , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight Message-ID: <20180118110226.GB4864@meghana-HP-Pavilion-Notebook> References: <87984b3cb205b19d50f3093e34c6dc8d8179b768.1516098341.git.meghana.madhyastha@gmail.com> <8e3ad1f2-b4df-10a4-844c-8bbc8801aaf5@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e3ad1f2-b4df-10a4-844c-8bbc8801aaf5@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 17, 2018 at 05:09:57PM +0000, Daniel Thompson wrote: > On 16/01/18 10:34, Meghana Madhyastha wrote: > >Add devm_of_find_backlight and the corresponding release > >function because some drivers use devres versions of functions > >for acquiring device resources. > > > >Signed-off-by: Meghana Madhyastha > >--- > > drivers/video/backlight/backlight.c | 29 +++++++++++++++++++++++++++++ > > include/linux/backlight.h | 7 +++++++ > > 2 files changed, 36 insertions(+) > > > >diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > >index 7e4a5d77d..b3f76945f 100644 > >--- a/drivers/video/backlight/backlight.c > >+++ b/drivers/video/backlight/backlight.c > >@@ -620,6 +620,35 @@ struct backlight_device *of_find_backlight(struct device *dev) > > } > > EXPORT_SYMBOL(of_find_backlight); > >+static void devm_backlight_put(void *data) > >+{ > >+ backlight_put(data); > > Shouldn't this be using devres_release()? backlight_put calls put_device which essentially does a release right? And looking at the code in other driver, looks like most of them use put_device (to the best of my knowledge, correct me if I'm mistaken). Thanks and regards, Meghana > > >+} > >+ > >+/** > >+ * devm_of_find_backlight - Resource-managed of_find_backlight() > >+ * @dev: Device > >+ * > >+ * Device managed version of of_find_backlight(). The reference on the backlight > >+ * device is automatically dropped on driver detach. > >+ */ > >+struct backlight_device *devm_of_find_backlight(struct device *dev) > >+{ > >+ struct backlight_device *bd; > >+ int ret; > >+ > >+ bd = of_find_backlight(dev); > >+ if (IS_ERR_OR_NULL(bd)) > >+ return bd; > >+ ret = devm_add_action(dev, devm_backlight_put, bd); > >+ if (ret) { > >+ backlight_put(bd); > >+ return ERR_PTR(ret); > >+ } > >+ return bd; > >+} > >+EXPORT_SYMBOL(devm_of_find_backlight); > >+ > > static void __exit backlight_class_exit(void) > > { > > class_destroy(backlight_class); > >diff --git a/include/linux/backlight.h b/include/linux/backlight.h > >index 32ea510da..1d373f5a6 100644 > >--- a/include/linux/backlight.h > >+++ b/include/linux/backlight.h > >@@ -215,11 +215,18 @@ of_find_backlight_by_node(struct device_node *node) > > #if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) > > struct backlight_device *of_find_backlight(struct device *dev); > >+struct backlight_device *devm_of_find_backlight(struct device *dev); > > #else > > static inline struct backlight_device *of_find_backlight(struct device *dev) > > { > > return NULL; > > } > >+ > >+static inline struct backlight_device * > >+devm_of_find_backlight(struct device *dev) > >+{ > >+ return NULL; > >+} > > #endif > > #endif > >