From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bp@alien8.de>
X-Google-Smtp-Source: ACJfBos9BqA8HUQK+3yw8+nXjZCjHGzSHCBxp7ImAP4uMQVlDrTy3C5nlr6CUqXMcd9HW52Df4js
ARC-Seal: i=1; a=rsa-sha256; t=1516275126; cv=none;
        d=google.com; s=arc-20160816;
        b=05LLhEH5M5sl3jl/TiCPTl9VGbUOOHmtTmRlzR9S9XNsZ5lRNd3jrWpnEvU4Rj3jM0
         KABH0sZTzZU6M7tjHvQdxl2Dr2kH1d0AAhP9gtl3nJXo8OE8m74NEE/ZHvb+JBmf1KKs
         WW0mDTWAPpACEIAthPsLODprBpVoxRu6bkhnxBT9bWZHTE1HnhJ9FmUghZYkaO63M/VB
         UD9ivvMNLASpC5HNicwOzbmNUOj8qCdoQmuviFfVGqSnFgfNf0fNh3QK0BwumR6wvPho
         Di43xXc6nbuQRtRcHPf84Oukzr8OsGZTI4aoSb8twpBThaqnPMad6t6ABAMsJ1U4D7Be
         MHTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :message-id:subject:cc:to:from:date:arc-authentication-results;
        bh=qnAuOMD8fceFkx0GthnLHXBROgJl3vRkMlupU9dJnSs=;
        b=06csv4qAA2mqqp7lyCjjUcL2FgaGy6d071JZTPXzUoK3nhkXBSzqSiiZmtjHHZwOsg
         EbHzlpe1OB++aXUsOYmPw4P+LqLWNWu8omU9fn5JC4Z5Sepc785yeM1sVkheFIsE7YdD
         rLQo0qwUV6UAfAWT7h2b/m+nVlItGMubDyf/+bZyiE1Vtvk80oK3Hezf2ZnREfkAnb6q
         uwUTxBEbJf44WkL9QUG1fwEBLN1WO/1KOpy/l2YvxTFV0xeMQ3PggDMm9QciXbOsMUtf
         eQSDSlW6Ci55hpOOFvv5nCiSWLOTGqtetAAuJZ8Ky18ZYf8cWw3ZywncuwXwJBFBxuBK
         24bA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de
Date: Thu, 18 Jan 2018 12:32:00 +0100
From: Borislav Petkov <bp@alien8.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>, linux-kernel@vger.kernel.org,
	Dave Hansen <dave.hansen@intel.com>,
	Ashok Raj <ashok.raj@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andi Kleen <ak@linux.intel.com>,
	Arjan Van De Ven <arjan.van.de.ven@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Asit Mallick <asit.k.mallick@intel.com>
Subject: Re: [PATCH v2 03/10] x86: Add a type field to alt_instr
Message-ID: <20180118113200.cr5lmpixrv2nd6jf@pd.tnic>
References: <20180116142825.376986833@infradead.org>
 <20180116143241.063773295@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180116143241.063773295@infradead.org>
User-Agent: NeoMutt/20170609 (1.8.3)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1589760004532516419?=
X-GMAIL-MSGID: =?utf-8?q?1589929706672159560?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Tue, Jan 16, 2018 at 03:28:28PM +0100, Peter Zijlstra wrote:
> Add a type field to the alternative description. For now this will be
> used to annotate static_cpu_has() but possible future uses include
> using it to implement alternative alignment and special NOP handling.
> 
> Suggested-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
>  arch/x86/include/asm/alternative-asm.h |    3 ++-
>  arch/x86/include/asm/alternative.h     |    6 +++++-

There's a

	DPRINTK("feat: %d*32+%d, old: (%p, len: %d), repl: (%p, len: %d), pad: %d",

in arch/x86/kernel/alternative.c which dumps the whole alt_instr struct
for debugging. Please add the type there too.

With that and Josh's suggestion added:

Reviewed-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.