From: Jerome Brunet <jbrunet@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/9] clk: meson: use frac parameter width instead of a constant
Date: Thu, 18 Jan 2018 19:45:27 +0100 [thread overview]
Message-ID: <20180118184532.6856-5-jbrunet@baylibre.com> (raw)
In-Reply-To: <20180118184532.6856-1-jbrunet@baylibre.com>
Use the fractional part width in the calculation instead of 12, which
happens to e the witdh right now. This is safer in case the field width
ever change in the future
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/meson/clk-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
index fa4cec13d6e8..d9efe725b7ad 100644
--- a/drivers/clk/meson/clk-pll.c
+++ b/drivers/clk/meson/clk-pll.c
@@ -80,7 +80,7 @@ static unsigned long meson_clk_pll_recalc_rate(struct clk_hw *hw,
reg = readl(pll->base + p->reg_off);
frac = PARM_GET(p->width, p->shift, reg);
- rate += (u64)parent_rate * frac >> 12;
+ rate += (u64)parent_rate * frac >> p->width;
rate *= 2;
}
--
2.14.3
next prev parent reply other threads:[~2018-01-18 18:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 18:45 [PATCH 0/9] clk: meson: pll fixes Jerome Brunet
2018-01-18 18:45 ` [PATCH 1/9] clk: meson: check pll rate param table before using it Jerome Brunet
2018-01-18 18:45 ` [PATCH 2/9] clk: meson: remove useless pll rate param tables Jerome Brunet
2018-01-18 18:45 ` [PATCH 3/9] clk: meson: remove unnecessary rounding in the pll clock Jerome Brunet
2018-01-19 2:06 ` Yixun Lan
2018-01-18 18:45 ` Jerome Brunet [this message]
2018-01-18 18:45 ` [PATCH 5/9] clk: meson: add od3 to the pll driver Jerome Brunet
2018-01-18 18:45 ` [PATCH 6/9] clk: meson: add gxl hdmi pll Jerome Brunet
2018-01-18 18:45 ` [PATCH 7/9] clk: meson: fix pll with fractional part calculation Jerome Brunet
2018-01-18 18:45 ` [PATCH 8/9] clk: meson: gxbb: add the fractional part of the fixed_pll Jerome Brunet
2018-01-18 18:45 ` [PATCH 9/9] clk: meson: axg: " Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118184532.6856-5-jbrunet@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=carlo@caione.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®