From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755314AbeASBQu (ORCPT ); Thu, 18 Jan 2018 20:16:50 -0500 Received: from gateway34.websitewelcome.com ([192.185.148.196]:15890 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754090AbeASBQm (ORCPT ); Thu, 18 Jan 2018 20:16:42 -0500 Date: Thu, 18 Jan 2018 18:55:18 -0600 Message-ID: <20180118185518.Horde.Y7_-NYMNMPQFQWHhAcwsWQL@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Stephen Hemminger Cc: "David S. Miller" , bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bridge: return boolean instead of integer in br_multicast_is_router References: <20180118233745.GA23355@embeddedor.com> <20180118162250.013954dd@xeon-e3> In-Reply-To: <20180118162250.013954dd@xeon-e3> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Source-L: Yes X-Exim-ID: 1ecKxk-002qMA-2U X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:22409 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 14 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stephen Hemminger : > On Thu, 18 Jan 2018 17:37:45 -0600 > "Gustavo A. R. Silva" wrote: > >> Return statements in functions returning bool should use >> true/false instead of 1/0. >> >> This issue was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva > > LGTM > > Fixes: 85b352693264 ("bridge: Fix build error when IGMP_SNOOPING is > not enabled") > Reviewed-by: Stephen Hemminger Thanks Stephen. -- Gustavo