From: Masami Hiramatsu <mhiramat@kernel.org>
To: "Woodhouse, David" <dwmw@amazon.co.uk>
Cc: mhiramat@kernel.org, "mingo@kernel.org" <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"ananth@linux.vnet.ibm.com" <ananth@linux.vnet.ibm.com>,
"gregkh@linux-foundation.org" <gregkh@linux-foundation.org>
Subject: Re: [PATCH v1 tip/master 1/3] retpoline: Introduce start/end markers of indirect thunk
Date: Fri, 19 Jan 2018 00:34:43 +0900 [thread overview]
Message-ID: <20180119003443.a58188a04552897d7fb78dbc@kernel.org> (raw)
In-Reply-To: <1516277170.4937.121.camel@amazon.co.uk>
On Thu, 18 Jan 2018 12:06:10 +0000
"Woodhouse, David" <dwmw@amazon.co.uk> wrote:
> On Thu, 2018-01-18 at 21:01 +0900, Masami Hiramatsu wrote:
> >
> > +#define X86_INDIRECT_THUNK(reg) \
> > + *(.text.__x86.indirect_thunk.##reg)
>
> Note that we don't actually care about those being in their own
> section, named after the register. That was just a hangover from the
> initial GCC COMDAT implementation.
>
> If it makes your life easier just to put them all in a single section,
> go ahead.
Got it. I just concerned that gcc was using this section.
I'll make it ".text.__x86.indirect_thunk" to consolidate.
Thanks!
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2018-01-18 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 12:00 [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline Masami Hiramatsu
2018-01-18 12:01 ` [PATCH v1 tip/master 1/3] retpoline: Introduce start/end markers of indirect thunk Masami Hiramatsu
2018-01-18 12:06 ` Woodhouse, David
2018-01-18 15:34 ` Masami Hiramatsu [this message]
2018-01-18 12:01 ` [PATCH v1 tip/master 2/3] kprobes/x86: Blacklist indirect thunk functions for kprobes Masami Hiramatsu
2018-01-18 12:02 ` [PATCH v1 tip/master 3/3] kprobes/x86: Disable optimizing on the function jumps to indirect thunk Masami Hiramatsu
2018-01-18 13:01 ` [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline Andi Kleen
2018-01-18 13:03 ` David Woodhouse
2018-01-18 18:50 ` Andi Kleen
2018-01-18 15:36 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119003443.a58188a04552897d7fb78dbc@kernel.org \
--to=mhiramat@kernel.org \
--cc=ak@linux.intel.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=arjan@linux.intel.com \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome