From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755419AbeASBSo (ORCPT ); Thu, 18 Jan 2018 20:18:44 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:51723 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754872AbeASBSe (ORCPT ); Thu, 18 Jan 2018 20:18:34 -0500 Date: Fri, 19 Jan 2018 02:11:18 +0100 From: Francois Romieu To: Peter Zijlstra Cc: Jia-Ju Bai , nic_swsd@realtek.com, alexander.h.duyck@redhat.com, David Miller , dhowells@redhat.com, paulmck@linux.vnet.ibm.com, will.deacon@arm.com, netdev@vger.kernel.org, Linux Kernel Mailing List Subject: Re: net: r8169: a question of memory barrier in the r8169 driver Message-ID: <20180119011118.GB15920@electric-eye.fr.zoreil.com> References: <9a373156-41e5-a78b-cd31-c4b9bdba2696@gmail.com> <20180118150658.GE2249@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180118150658.GE2249@hirez.programming.kicks-ass.net> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra : [...] > There is only 1 variable afaict. Memory barriers need at least 2 in > order to be able to do _anything_. I don't get your point: why don't {cur_tx, dirty_tx} qualify as said two variables ? -- Ueimor