From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753153AbeASEjS (ORCPT ); Thu, 18 Jan 2018 23:39:18 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35196 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbeASEjL (ORCPT ); Thu, 18 Jan 2018 23:39:11 -0500 X-Google-Smtp-Source: ACJfBovOQcIZiXsGxXB8zFTlk3YWa4mosHRE/ER+zaQ14qKVzb9KB03sOTnO98GuuOa43CZz3o12Gg== From: Sergey Senozhatsky X-Google-Original-From: Sergey Senozhatsky To: Petr Mladek , Steven Rostedt Cc: linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: [PATCH] printk: drop redundant devkmsg_log_str memsets Date: Fri, 19 Jan 2018 13:39:01 +0900 Message-Id: <20180119043901.1728-1-sergey.senozhatsky@gmail.com> X-Mailer: git-send-email 2.16.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We copy in null terminated strings "on" and "off", no need to zero out devkmsg_log_str in control_devkmsg(). Signed-off-by: Sergey Senozhatsky --- kernel/printk/printk.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index d70927c384f3..9faddcfd3994 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -136,13 +136,10 @@ static int __init control_devkmsg(char *str) /* * Set sysctl string accordingly: */ - if (devkmsg_log == DEVKMSG_LOG_MASK_ON) { - memset(devkmsg_log_str, 0, DEVKMSG_STR_MAX_SIZE); - strncpy(devkmsg_log_str, "on", 2); - } else if (devkmsg_log == DEVKMSG_LOG_MASK_OFF) { - memset(devkmsg_log_str, 0, DEVKMSG_STR_MAX_SIZE); - strncpy(devkmsg_log_str, "off", 3); - } + if (devkmsg_log == DEVKMSG_LOG_MASK_ON) + strcpy(devkmsg_log_str, "on"); + else if (devkmsg_log == DEVKMSG_LOG_MASK_OFF) + strcpy(devkmsg_log_str, "off"); /* else "ratelimit" which is set by default. */ /* -- 2.16.0