From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753505AbeASEre (ORCPT ); Thu, 18 Jan 2018 23:47:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbeASEr0 (ORCPT ); Thu, 18 Jan 2018 23:47:26 -0500 Date: Fri, 19 Jan 2018 12:47:19 +0800 From: Dave Young To: Steven Rostedt Cc: Andi Kleen , pmladek@suse.com, sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, kexec@lists.infradead.org Subject: Re: [PATCH] print kdump kernel loaded status in stack dump Message-ID: <20180119044719.GA3985@dhcp-128-65.nay.redhat.com> References: <20180117045057.GA4994@dhcp-128-65.nay.redhat.com> <878tcvt592.fsf@linux.intel.com> <20180118135704.62d0f79f@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180118135704.62d0f79f@gandalf.local.home> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/18/18 at 01:57pm, Steven Rostedt wrote: > On Thu, 18 Jan 2018 10:02:17 -0800 > Andi Kleen wrote: > > > Dave Young writes: > > > printk("%sHardware name: %s\n", > > > log_lvl, dump_stack_arch_desc_str); > > > + if (kexec_crash_loaded()) > > > + printk("%skdump kernel loaded\n", log_lvl); > > > > Oops/warnings are getting longer and longer, often scrolling away > > from the screen, and if the kernel crashes backscroll does not work > > anymore, so precious information is lost. > > > > Can you merge it with some other line? > > > > Just a [KDUMP] or so somewhere should be good enough. > > Or perhaps we should add it as a TAINT. Not all taints are bad. Hmm, I also thought about this before but It sounds like not match the "tainted" meaning with the assumption that it is bad :( Maybe it would be better to do like Andi said, but print a better word than "KDUMP", eg. "Kdumpable" sounds better. If this is fine I can repost the patch. > > -- Steve Thanks Dave