mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: mingo@redhat.com, oleg@redhat.com, srikar@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org, namhyung@kernel.org
Subject: Re: [PATCH] trace_uprobe: Display correct offset in uprobe_events
Date: Fri, 19 Jan 2018 11:04:46 -0500	[thread overview]
Message-ID: <20180119110446.3d040c5f@gandalf.local.home> (raw)
In-Reply-To: <20180106054246.15375-1-ravi.bangoria@linux.vnet.ibm.com>

On Sat,  6 Jan 2018 11:12:46 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:

> Recently, how the pointers being printed with %p has been changed
> by commit ad67b74d2469 ("printk: hash addresses printed with %p").
> This is causing a regression while showing offset in the
> uprobe_events file. Instead of %p, use %px to display offset.
> 
> Before patch:
> 
>   # perf probe -vv -x /tmp/a.out main
>   Opening /sys/kernel/debug/tracing//uprobe_events write=1
>   Writing event: p:probe_a/main /tmp/a.out:0x58c
> 
>   # cat /sys/kernel/debug/tracing/uprobe_events
>   p:probe_a/main /tmp/a.out:0x0000000049a0f352
> 
> After patch:
> 
>   # cat /sys/kernel/debug/tracing/uprobe_events
>   p:probe_a/main /tmp/a.out:0x000000000000058c
> 

Thanks, I'll pull this into my tree.

-- Steve

      parent reply	other threads:[~2018-01-19 16:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-06  5:42 Ravi Bangoria
2018-01-08  5:19 ` Srikar Dronamraju
2018-01-08  6:31   ` Ravi Bangoria
2018-01-08  6:35     ` Tobin C. Harding
2018-01-08 13:58       ` Srikar Dronamraju
2018-01-19 16:04 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180119110446.3d040c5f@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=oleg@redhat.com \
    --cc=ravi.bangoria@linux.vnet.ibm.com \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®