From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754655AbeASLGr (ORCPT ); Fri, 19 Jan 2018 06:06:47 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:41034 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754693AbeASLGj (ORCPT ); Fri, 19 Jan 2018 06:06:39 -0500 X-Google-Smtp-Source: ACJfBos5QLhDcJopvdcSkJa2dygbYZvM52HTuDQ/6OoWvzfJpOI6VwhXXv1Q1fla59FgeRDjwvwHpw== Date: Fri, 19 Jan 2018 11:06:35 +0000 From: Daniel Thompson To: Meghana Madhyastha Cc: Lee Jones , Jingoo Han , Thierry Reding , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Tomi Valkeinen , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v17 05/10] video: backlight: Add devres versions of of_find_backlight Message-ID: <20180119110635.bwf3gb3ee3zby7z2@oak.lan> References: <021f8fecfa3f374dc5dcb70fb07a6f6b019bea7b.1516358037.git.meghana.madhyastha@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <021f8fecfa3f374dc5dcb70fb07a6f6b019bea7b.1516358037.git.meghana.madhyastha@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 19, 2018 at 10:44:33AM +0000, Meghana Madhyastha wrote: > Add devm_of_find_backlight and the corresponding release > function because some drivers use devres versions of functions > for acquiring device resources. > > Signed-off-by: Meghana Madhyastha Acked-by: Daniel Thompson > --- > changes in v17: > -fix checkpath errors/warnings > -rename devm_backlight_put to > devm_backlight_release > > drivers/video/backlight/backlight.c | 30 ++++++++++++++++++++++++++++++ > include/linux/backlight.h | 7 +++++++ > 2 files changed, 37 insertions(+) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index 553bf5c48..deb824bef 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -623,6 +623,36 @@ struct backlight_device *of_find_backlight(struct device *dev) > } > EXPORT_SYMBOL(of_find_backlight); > > +static void devm_backlight_release(void *data) > +{ > + backlight_put(data); > +} > + > +/** > + * devm_of_find_backlight - Resource-managed of_find_backlight() > + * @dev: Device > + * > + * Device managed version of of_find_backlight(). > + * The reference on the backlight device is automatically > + * dropped on driver detach. > + */ > +struct backlight_device *devm_of_find_backlight(struct device *dev) > +{ > + struct backlight_device *bd; > + int ret; > + > + bd = of_find_backlight(dev); > + if (IS_ERR_OR_NULL(bd)) > + return bd; > + ret = devm_add_action(dev, devm_backlight_release, bd); > + if (ret) { > + backlight_put(bd); > + return ERR_PTR(ret); > + } > + return bd; > +} > +EXPORT_SYMBOL(devm_of_find_backlight); > + > static void __exit backlight_class_exit(void) > { > class_destroy(backlight_class); > diff --git a/include/linux/backlight.h b/include/linux/backlight.h > index ddc9bade4..2baab6f38 100644 > --- a/include/linux/backlight.h > +++ b/include/linux/backlight.h > @@ -217,11 +217,18 @@ of_find_backlight_by_node(struct device_node *node) > > #if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) > struct backlight_device *of_find_backlight(struct device *dev); > +struct backlight_device *devm_of_find_backlight(struct device *dev); > #else > static inline struct backlight_device *of_find_backlight(struct device *dev) > { > return NULL; > } > + > +static inline struct backlight_device * > +devm_of_find_backlight(struct device *dev) > +{ > + return NULL; > +} > #endif > > #endif > -- > 2.11.0 >