From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-4085019-1516373127-3-2602714272199869236 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Attached: signature.asc X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516373127; b=SeCLf8i6MPiJgaFdOSraawvsIF6RkfLM3J++rMxmbJEtTbU ib6Em/9meG4uC6/SVoY0i27N8UUagVlQpfWcY/oOnKeGkQFujN3PDZG7aduasbWq g/SQgl7u1lbM5BxnQSoaFlcY65WGmvEHDAGTog+Go5ugT1YS3SmQtP7l9d9DMlWa curwr26E11OqNI0wgt+kgOeJ3HVAFSraQRGYM1FQ0NNI4dIiSVqOEyNt1k14yUJg HTEDj5fWRawh7mUgOjNxg9SarZYRkYe9i679imimGsFPx6/wnacHytx30iRkl8xi vVTD9LCrrHlqfG1eeVim0R61/e8Ohm0rb7Nts1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1516373127; bh=y2sHhGDDZzIlHTEkLFQVEVyDuE d/Yn40bifG1YxAJmE=; b=UiMOdzHWQG9xKYGrf5BMma2pv37Ny+Mlit69gJ4f8W sfT9eHDsYvm/ZxJaNImR1jnGxwOEmsADdyfbmh2Z09FfLrVq2CAylvzLD6z91/ju PeIZxx4rOQSy8KKrjqJzg5UPrlzgitv8HEP1a5794C9m19284pM7v6iFDUV7kroA OO6KsBIaQl0OeRc2w2hegY4431gc+gJ/zBqZ0RvzV1fxQYx7eAl1OYKH3QesZpZk oyrga3C58Wg8ne7Svo9L12ZQEYTTgR5I6FGloRMttl9Qg5DmJua5BAgGziHplvi/ 9287cuIV06nZw351Y/v+AVEOIyNVwgFGBjICqENFQp6w== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=free-electrons.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=free-electrons.com header.result=pass header_is_org_domain=yes Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=free-electrons.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=free-electrons.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754719AbeASOpY (ORCPT ); Fri, 19 Jan 2018 09:45:24 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:42525 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753332AbeASOpY (ORCPT ); Fri, 19 Jan 2018 09:45:24 -0500 X-Remote-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Remote-Spam-Level: X-Remote-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Date: Fri, 19 Jan 2018 15:45:12 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Kishon Vijay Abraham I , Hans de Goede , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, stable@vger.kernel.org Subject: Re: [PATCH] phy: allwinner: sun4i-usb: poll vbus changes on A23/A33 when driving VBUS Message-ID: <20180119144512.dqqbywavhwsyma2f@flea.lan> References: <20180119092541.7508-1-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b36vrdl5wjpiofow" Content-Disposition: inline In-Reply-To: <20180119092541.7508-1-wens@csie.org> User-Agent: NeoMutt/20171215 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: --b36vrdl5wjpiofow Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 19, 2018 at 05:25:41PM +0800, Chen-Yu Tsai wrote: > The AXP223 PMIC, like the AXP221, does not generate VBUS change > interrupts when N_VBUSEN is used to drive VBUS for the OTG port > on the board. >=20 > This was not noticed until recently, as most A23/A33 boards use > a GPIO pin that does not support interrupts for OTG ID detection. > This forces the driver to use polling. However the A33-OlinuXino > uses a pin that does support interrupts, so the driver uses them. > However the VBUS interrupt never fires, and the driver never gets > to update the VBUS status. This results in musb timing out waiting > for VBUS to rise. >=20 > This was worked around for the AXP221 by resorting to polling > changes in commit 91d96f06a760 ("phy-sun4i-usb: Add workaround for > missing Vbus det interrupts on A31"). This patch adds the A23 and > A33 to the list of SoCs that need the workaround. >=20 > Fixes: fc1f45ed3043 ("phy-sun4i-usb: Add support for the usb-phys on the > sun8i-a33 SoC") > Fixes: 123dfdbcfaf5 ("phy-sun4i-usb: Add support for the usb-phys on the > sun8i-a23 SoC") > Cc: # 4.3.x: 68dbc2ce77bb phy-sun4i-usb: > Use of_match_node to get model specific config data > Cc: # 4.3.x: 5cf700ac9d50 phy: phy-sun4i-usb: > Fix optional gpios failing probe > Cc: # 4.3.x: 04e59a0211ff phy-sun4i-usb: > Fix irq free conditions to match request conditions > Cc: # 4.3.x: 91d96f06a760 phy-sun4i-usb: > Add workaround for missing Vbus det interrupts on A31 > Cc: # 4.3.x > Signed-off-by: Chen-Yu Tsai > --- >=20 > This list might get longer if the newer AXP8xx PMICs also have this > behavior. We could switch to a boolean in the per-compatible data, > or just always use polling. The yet-merged R40 support will have this > issue as well, as the R40 is paired with the AXP221. But for now, > I'd like to have something that is easier to backport to stable, so > we can at least fix this for the A23 and A33. >=20 > Also, checkpatch.pl doesn't like the stable kernel prerequisite lines. Acked-by: Maxime Ripard Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --b36vrdl5wjpiofow Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlpiBHcACgkQ0rTAlCFN r3TSexAAhhwV2h9Bm98/Zi+O9Sh8pgaY35HVbnHkE+LD8xC4V4U4ccA69QQ7LUWM iE0HFYy8dSM7gN6ofuox1q0n9I+nWOYB048COlCgL70KWRHElKWbteGLQX8etZtI 3+nPLny0+k/NE2rC81/1WIHr1zH3m7nePfXhnwJa3+ZyKInQ0woI7h0xy+18NQry KEaC4P1mQs1yb5I+ZYhkMuRV+2wtvXCotDeIJ4nvHghfPADIjHTXwS8H51s7xL+8 0oHiWlQSHcew2qVbvRU2i/FD1+qGVwIVmXsKzxGWgXa55NyJtCcUGxqlUzcG2cv1 RTWwkUbOJlvB/eAozHLtTsuFwBR8FGtjkRc9RWn4IEq7IjmrKQTE2+4QddRhzB0t MAap2q7OYyzS00ARuIvroT5ieDPEOJH+hdz3yW8c93D8pYd+Deh/fFXi1GT2rH7t x4hpw/qU76Ux2GOpjX90hWmG5MwcKj3iPxOxBajGGwolOIN0DFrR5JFDVZc0BkVd a8ulDb1LQ7KvFKczmFsuF4kSm58Pn/auoPb+BPFxtSYAXtELIsAcIFNbi/AdJyro GCcqpr5QrdDiVls/d0kBLn0dSKALJ2EntvYmMK3Y84IV6Ga8y9W4rEazDaG+5QNh KCW+f9Z/n/NubAqs6mTr1Et7oo/NTD6Ti+EU86R+0Bl6YKMdifA= =+z6Z -----END PGP SIGNATURE----- --b36vrdl5wjpiofow--