From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756153AbeASPbm (ORCPT ); Fri, 19 Jan 2018 10:31:42 -0500 Received: from mx2.suse.de ([195.135.220.15]:45958 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755030AbeASPbg (ORCPT ); Fri, 19 Jan 2018 10:31:36 -0500 Date: Fri, 19 Jan 2018 16:31:32 +0100 From: Michal Hocko To: Shakeel Butt Cc: Andrey Ryabinin , Andrew Morton , Cgroups , LKML , Linux MM , Johannes Weiner , Vladimir Davydov Subject: Re: [PATCH v5 2/2] mm/memcontrol.c: Reduce reclaim retries in mem_cgroup_resize_limit() Message-ID: <20180119153132.GF6584@dhcp22.suse.cz> References: <20171220102429.31601-1-aryabinin@virtuozzo.com> <20180119132544.19569-1-aryabinin@virtuozzo.com> <20180119132544.19569-2-aryabinin@virtuozzo.com> <20180119133510.GD6584@dhcp22.suse.cz> <20180119151118.GE6584@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 19-01-18 07:24:08, Shakeel Butt wrote: [...] > Thanks for the explanation. Another query, we do not call > drain_all_stock() in mem_cgroup_resize_limit() but memory_max_write() > does call drain_all_stock(). Was this intentional or missed > accidentally? I think it is just an omission. I would have to look closer but I am just leaving now and will be back on Tuesday. This is unrelated so I would rather discuss it in a separate email thread. -- Michal Hocko SUSE Labs