From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756105AbeASRO7 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 19 Jan 2018 12:14:59 -0500
Received: from bombadil.infradead.org ([65.50.211.133]:57739 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755830AbeASROw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 19 Jan 2018 12:14:52 -0500
Date: Fri, 19 Jan 2018 18:14:42 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jia-Ju Bai <baijiaju1990@gmail.com>, nic_swsd@realtek.com,
        alexander.h.duyck@redhat.com, David Miller <davem@davemloft.net>,
        dhowells@redhat.com, paulmck@linux.vnet.ibm.com, will.deacon@arm.com,
        netdev@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: net: r8169: a question of memory barrier in the r8169 driver
Message-ID: <20180119171442.GY2228@hirez.programming.kicks-ass.net>
References: <9a373156-41e5-a78b-cd31-c4b9bdba2696@gmail.com>
 <20180118150658.GE2249@hirez.programming.kicks-ass.net>
 <20180119011118.GB15920@electric-eye.fr.zoreil.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180119011118.GB15920@electric-eye.fr.zoreil.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 19, 2018 at 02:11:18AM +0100, Francois Romieu wrote:
> Peter Zijlstra <peterz@infradead.org> :
> [...]
> > There is only 1 variable afaict. Memory barriers need at least 2 in
> > order to be able to do _anything_.
> 
> I don't get your point: why don't {cur_tx, dirty_tx} qualify as said
> two variables ?

There wasn't any cur_tx in the code you provided.