From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBota/wSEfgsh+z6+k42Eq4y/8EAgQ3So0b18mbsI8BdXt6dL4eSdeJ46gJc7SYPbAEuk2kmd ARC-Seal: i=1; a=rsa-sha256; t=1516385055; cv=none; d=google.com; s=arc-20160816; b=flo9Gul9h2DHC54hx3jreFUXlSGc4Ydo6jxZVGTvL8WWNQu82vCWt9sfHe8/TZNG/+ uzRCyiriT111Wj1ymNjtpVxjan1q+qCMC60Bk0GTLRPy8+tS3d2A47HM6Ei43miS2Khm wAxE3/OtRTweE9eTXok9/lSXJeEdSP8ubbsLQwhp1VX23OHFg9E0N3o6LKd6WLtjXhjr lkf2GKwCHPMCQXZlJXz6rvwD84+GqzCL8uKdELO9knqniAEAvYBrXTxg9PGJ271F0Ksa MpADLCA5i/BKMxetnqY1S0PnPOska80ouPzbUf23J6Rg0PydithvO+eCyA+vWmnZUC0w 6DFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:sender:date :arc-authentication-results; bh=8SIDwfg8Ro3Pu+wR3fKb+uGABYp0rfBMgrlolvkPe5s=; b=GNlGOFA3C9GE3mkVZHXbpx3uEvmwRaOrdvS0dBV5IqsAshAx4H+QERc1ZyvwisFVdb Tw3QZiGP69su7TTEiLwLrKchvufIlpOGdLwcFl7w6t5NkIUx57JW0YoAi/PU+P1fvQcO hPzZqv8AKs1zcuQUVmo7GO87GMqJALZkMfdXjM0bcLLvWGP78mHrfLm5+oInnQCVbuc2 N98qqjf82luOoqgZjb35FwbBsAXY+GXQSjeT4Zwr0yeriz71/M2GHavq79sG1IXX0pL8 3HNDqbVV8tPaeomT6PlWfD3ZELqxGXL3a6lL+ziEC7MT17nsjS5s7tjcREyJQYmyWIcd 5Uyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of ladis@linux-mips.org designates 148.251.95.138 as permitted sender) smtp.mailfrom=ladis@linux-mips.org Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of ladis@linux-mips.org designates 148.251.95.138 as permitted sender) smtp.mailfrom=ladis@linux-mips.org Date: Fri, 19 Jan 2018 19:04:08 +0100 Sender: Ladislav Michl From: Ladislav Michl To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Wolfram Sang , Bjorn Helgaas , Greg Kroah-Hartman , Thomas Gleixner Subject: [PATCH 1/2] devres: Fix double mem region release in devm_ioremap_resource() Message-ID: <20180119180408.GB31540@lenoch> References: <20180119180310.GA31540@lenoch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180119180310.GA31540@lenoch> User-Agent: Mutt/1.9.2 (2017-12-15) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590044976545781438?= X-GMAIL-MSGID: =?utf-8?q?1590044976545781438?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: devm_release_mem_region() is called explicitely in case devm_ioremap() fails, however the same release function is later called also as devres release of devm_request_mem_region() causing double resource free. Fixes: 72f8c0bfa0de ("lib: devres: add convenience function to remap a resource") Signed-off-by: Ladislav Michl --- lib/devres.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/devres.c b/lib/devres.c index 5f2aedd58bc5..584356a568d0 100644 --- a/lib/devres.c +++ b/lib/devres.c @@ -156,7 +156,6 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res) dest_ptr = devm_ioremap(dev, res->start, size); if (!dest_ptr) { dev_err(dev, "ioremap failed for resource %pR\n", res); - devm_release_mem_region(dev, res->start, size); dest_ptr = IOMEM_ERR_PTR(-ENOMEM); } -- 2.15.1