From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-218731-1516388788-2-16419152987091905589 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='de', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-api-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516388787; b=jEc5lsEQTvz0Rb6zp1GcKsqqVxPgmjySVad3nzb0X+o/ODN kRc9mhClVcwkuZdHj5dFTIHrOz5eechTY52GjAxypQA/c2yiSgyEt5c9SOXPRrGa ciWVMVnC/At5rkxotrzen8q9OWWXiUoOtYO9brk5YFa5k0mzvRQ2SDu8/YtafbPl /HmFK8b/xq+FNVUYBVyriBwjoTFe+gf6vf7cduyzwMygb8qkQrJhfIALEifHa4Ti ae7OOZn84ZSqdduezmdfGZ6eghseCH0mtqdYBh+jt7iDHMxf/wa6dkkeAWZLJ14X KaNH1cCszrGJ12C1OIwXFsTuFwznsJa5gdYpztQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1516388787; bh=eTYysb17PoEwnKAwnUG7Lu2XQ6 LuaUdFYc5XTU5v2xg=; b=d+qxwmvmfvk2aDIQWXc+GQyxmXD7MCaGaDTlc+CLmn hcBLerlD1G2nV6SqD9fjTNB3W05R1dEBpwV0U3KcTNmkH9upY94j3KbQFNLC1E2X xt8VFVO9ublzAjHlpzX6sYuPmswkVZSta2KciS541XcsExzhB7rsLu3Of0C37i1c 2VwHAIsshhOVaEk8Ji5I5hJqH//lXo4YnG4/cBMn+oenL3l3A6cQKXe5RXsxZl/u S0yKP9LoOhhGl1YhqrUNOkG2JOJLFavqOFWO23ONeUJH+38T/Ey41Pxrn/pQ5AiP zR0XYaDpSpMjf3BAyxjfZ363mErO/DdcSJ9INuOs4P+w== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=lst.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=lst.de header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=lst.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=lst.de header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755993AbeASTGL (ORCPT ); Fri, 19 Jan 2018 14:06:11 -0500 Received: from verein.lst.de ([213.95.11.211]:41337 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755830AbeASTGL (ORCPT ); Fri, 19 Jan 2018 14:06:11 -0500 Date: Fri, 19 Jan 2018 20:06:09 +0100 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: aio fsync revisited Message-ID: <20180119190609.GA19772@lst.de> References: <20180117194747.1631-1-hch@lst.de> <20180118224614.GI16421@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180118224614.GI16421@dastard> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-api-owner@vger.kernel.org X-Mailing-List: linux-api@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, Jan 19, 2018 at 09:46:14AM +1100, Dave Chinner wrote: > After I get back from LCA (all next week) I'll update the fsmark > aio patches I have and retest this. The code looks pretty similar to > the last "generic aio fsync" patch I wrote, so I'm guessing that the > results will be pretty similar, too. Your patch applied as-is, as that's what I've been using to test the feature. Howerever I needed the following fixups to actually make the compiler and linker happy: diff --git a/Makefile b/Makefile index 9b75ce3..ce5f54b 100644 --- a/Makefile +++ b/Makefile @@ -11,13 +11,14 @@ DIR2= /test/dir2 COBJS= fs_mark.o lib_timing.o CFLAGS= -O2 -Wall -D_FILE_OFFSET_BITS=64 +LDFLAGS= -laio all: fs_mark fs_mark.o: fs_mark.c fs_mark.h fs_mark: fs_mark.o lib_timing.o - ${CC} -o fs_mark fs_mark.o lib_timing.o + ${CC} ${LDFLAGS} -o fs_mark fs_mark.o lib_timing.o test: fs_mark ./fs_mark -d ${DIR1} -d ${DIR2} -s 51200 -n 4096 diff --git a/fs_mark.c b/fs_mark.c index 8f8fb84..4a4103d 100644 --- a/fs_mark.c +++ b/fs_mark.c @@ -135,7 +135,7 @@ get_fsync_completions(int threshold) aio_flight -= r; for (i = 0; i < r; ++i) { if (ioevents[i].res) - printf("FAIL! aio_fsync returned %d\n", + printf("FAIL! aio_fsync returned %zd\n", ioevents[i].res); } usleep(1000); @@ -162,6 +162,7 @@ do_fsync(int fd) cleanup_exit(); } + return 0; } /*