From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1734268-1516458843-2-2981896527576393144 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FSL_HELO_FAKE 3.899, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-serial-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516458842; b=LboSZHEolH+xTOmuM652XMAU+kzggI5QtV3mBhDWsIrmtOC YB7gLld4UOWg8uWDlUETAW07p9TMcSCpL4EZUe8P49tvuWbawkKi8HLgJoPEQ+/D 4SRnjGSt44F4kqP5qDEatsZkj2YNKC+jvH9VDvb6AZUw0FNwnjA/5QlFwFs1srmC DWZxQJMeFSGljXuGgcH52QXrVnAVYGLz1FLExwRqPP1NsS0eWHCxNzJDcTWW2uDq RvQEAAbD3TX6/N6+sjxFD553/DNuMzPtDKP1tw+a20v5MGQusybi85c1vVaDWU7X 1fe91zgpV+K2FSQVssKR3oB9YoHbCmEf/iuTSpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1516458842; bh=HtW7Ali6s+fVlHfxwboz0KybeS zM6hH3ulLAABwRm3A=; b=TS32DL/aQUg6fQoTGTQkUCqGUziLtnGzwfonUDHj/e e+eCzjOhYHwd7AuyPCwah2OpgDCclA3cD7PgkcVl/e9ugKlrlfu9SaWnbdoZeH5S GArZNjCcK3D3qaqLuZ/b3w6pnwEma0NEsS30FR97HZZ06FRu+fQMBxSi0xaXNISQ QKj3p+Lh3BBUzQaSfYGQ6AG1x5cMwxjC+FnwazL3DgQC8flUUbFIO8aTpPcA1Drk 77yTjHSiUb6KbaAoW7iDErXi2WBX2YzbvBYzPDEtBYbAJPj91wIsQ60HP7ojbqlO VM40z2Lrd302h6FBVtIqDo53Wo2Zo5q/tDK2/7iAlKoQ== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=aqV17r3c x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-serial-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=hbI9jWeu; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=aqV17r3c x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-serial-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=hbI9jWeu; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754301AbeATOd6 (ORCPT ); Sat, 20 Jan 2018 09:33:58 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:44095 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbeATOd4 (ORCPT ); Sat, 20 Jan 2018 09:33:56 -0500 X-Google-Smtp-Source: AH8x226Ktnh0WzRostm82najsR55C+0cHuFvbJDfu6UVeS0tJvrvv29+EnN2VOam6zPFGMLKkNfxeg== Date: Sat, 20 Jan 2018 15:33:51 +0100 From: Ingo Molnar To: Prarit Bhargava Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, Bhupesh Sharma , Lv Zheng , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Jonathan Corbet , Catalin Marinas , Will Deacon , Timur Tabi , graeme.gregory@linaro.org, mark.salter@redhat.com Subject: Re: [PATCH] acpi, spcr: Make SPCR available to x86 Message-ID: <20180120143351.gmjpnqczaa2zov4o@gmail.com> References: <20180118150951.28964-1-prarit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180118150951.28964-1-prarit@redhat.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-serial-owner@vger.kernel.org X-Mailing-List: linux-serial@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: * Prarit Bhargava wrote: > Note on testing: I've tested this on several ARM64 and x86 boxes (only > earlycon, console=ttyS0,115200, and with both options), verified that > functionality on ARM64 has not changed (ie, CONFIG_ACPI_SPCR_TABLE is > always =y), and verified functionality when !CONFIG_ACPI_SPCR_TABLE on > x86. > > P. > > ----8<---- > > SPCR is currently only enabled or ARM64 and x86 can use SPCR to setup an > early console. > > General fixes include updating Documentation & Kconfig (for x86), updating > comments, and changing parse_spcr() to acpi_parse_spcr(), and > earlycon_init_is_deferred to earlycon_acpi_spcr_enable to be more > descriptive. > > On x86, many systems have a valid SPCR table but the table version is not > 2 so the table version check must be a warning. > > On ARM64 when the kernel parameter earlycon is used both the early console > and console are enabled. On x86, only the earlycon should be enabled by > by default. Modify acpi_parse_spcr() to allow options for initializing > the early console and console separately. > > Signed-off-by: Prarit Bhargava > Cc: linux-acpi@vger.kernel.org > Cc: linux-doc@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-pm@vger.kernel.org > Cc: linux-serial@vger.kernel.org > Cc: Bhupesh Sharma > Cc: Lv Zheng > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Jonathan Corbet > Cc: Catalin Marinas > Cc: Will Deacon > Cc: "Rafael J. Wysocki" Mrjw@rjwysocki.net> > Cc: Timur Tabi > Cc: graeme.gregory@linaro.org > Cc: mark.salter@redhat.com > --- > Documentation/admin-guide/kernel-parameters.txt | 9 +++++--- > arch/arm64/kernel/acpi.c | 4 ++-- > arch/x86/kernel/acpi/boot.c | 3 +++ > drivers/acpi/Kconfig | 7 +++++- > drivers/acpi/spcr.c | 29 +++++++++++++------------ > drivers/tty/serial/earlycon.c | 15 +++++-------- > include/linux/acpi.h | 7 ++++-- > include/linux/serial_core.h | 4 ++-- > 8 files changed, 44 insertions(+), 34 deletions(-) I'm fine with the x86 aspect of this: Acked-by: Ingo Molnar > earlycon= [KNL] Output early console device and options. > > - When used with no options, the early console is > - determined by the stdout-path property in device > - tree's chosen node. > + [ARM64] The early console is determined by the > + stdout-path property in device tree's chosen node, > + or determined by the ACPI SPCR table. s/in device tree's chosen node /in the device tree's chosen node Thanks, Ingo