From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751244AbeAUU3P (ORCPT ); Sun, 21 Jan 2018 15:29:15 -0500 Received: from e2big.org ([198.61.226.133]:53231 "EHLO e2big.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbeAUU3O (ORCPT ); Sun, 21 Jan 2018 15:29:14 -0500 Date: Sun, 21 Jan 2018 21:10:50 +0100 From: ulrik.debie-os@e2big.org To: Dmitry Torokhov Cc: Aaron Ma , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported Message-ID: <20180121201049.GA23310@beacon.debie> References: <20180112064658.25019-1-aaron.ma@canonical.com> <20180112083940.p36qj6ltzzwtuhng@dtor-ws> <06bbeca0-8a90-8935-9be3-f154db0b9fe9@canonical.com> <20180112181830.ccpkltghgkj3oh3e@dtor-ws> <6a96ce54-9f8a-2424-1e48-34ec6445cb8f@canonical.com> <20180116230713.rppztybwe5ufhoxo@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180116230713.rppztybwe5ufhoxo@dtor-ws> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-Spam_report: Spam detection software, running on the system "e2big.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: On Tue, Jan 16, 2018 at 03:07:13PM -0800, Dmitry Torokhov wrote: Hi Dmitry, > > On Sat, Jan 13, 2018 at 10:34:19AM +0800, Aaron Ma wrote: > > Will your patch go to stable kernel? > > If yes, that's fine. > > Hmm, it looks like we need this patch after all as we do have screwy > Lenovos with apparently 0x01 devices reporting 0 buttons. From > https://bugzilla.kernel.org/show_bug.cgi?id=196253 > > thinkpad_acpi: ThinkPad BIOS R0DET87W (1.87 ), EC unknown > thinkpad_acpi: Lenovo ThinkPad E470, model 20H1004SGE > > psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 0/0 > > I'll ask them to try my patch and if it is indeed 0x01 device I'll apply > your patch. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 16, 2018 at 03:07:13PM -0800, Dmitry Torokhov wrote: Hi Dmitry, > > On Sat, Jan 13, 2018 at 10:34:19AM +0800, Aaron Ma wrote: > > Will your patch go to stable kernel? > > If yes, that's fine. > > Hmm, it looks like we need this patch after all as we do have screwy > Lenovos with apparently 0x01 devices reporting 0 buttons. From > https://bugzilla.kernel.org/show_bug.cgi?id=196253 > > thinkpad_acpi: ThinkPad BIOS R0DET87W (1.87 ), EC unknown > thinkpad_acpi: Lenovo ThinkPad E470, model 20H1004SGE > > psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 0/0 > > I'll ask them to try my patch and if it is indeed 0x01 device I'll apply > your patch. It is quite strange. In the past,for commit 293b915fd9be "Input: trackpoint - assume 3 buttons when buttons detection fails" there was success reported for lenovo e470 and I see the same success report in that bugzilla ticket. I can also report success on lenovo e570. But some seem to have problems, could it be that they are not including that commit in the kernel they are running ? Or did a bios upgrade change the behaviour ? It would be best when we have a confirmation from a e470 owner that without the proposed patch from Aaron the middle button does not work on his e470, and it works with it. Kind regards, Ulrik