From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751157AbeAVO1k (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 Jan 2018 09:27:40 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:34534 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751092AbeAVO1i (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Jan 2018 09:27:38 -0500
Date: Mon, 22 Jan 2018 09:27:37 -0500 (EST)
Message-Id: <20180122.092737.278179232055886032.davem@davemloft.net>
To: colin.king@canonical.com
Cc: arkadis@mellanox.com, jiri@mellanox.com, netdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] devlink: fix memory leak on 'resource'
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180122103119.4801-1-colin.king@canonical.com>
References: <20180122103119.4801-1-colin.king@canonical.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Colin King <colin.king@canonical.com>
Date: Mon, 22 Jan 2018 10:31:19 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently, if the call to devlink_resource_find returns null then
> the error exit path does not free the devlink_resource 'resource'
> and a memory leak occurs. Fix this by kfree'ing resource on the
> error exit path.
> 
> Detected by CoverityScan, CID#1464184 ("Resource leak")
> 
> Fixes: d9f9b9a4d05f ("devlink: Add support for resource abstraction")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks Colin.