From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751662AbeAVUZS (ORCPT ); Mon, 22 Jan 2018 15:25:18 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:40294 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbeAVUZP (ORCPT ); Mon, 22 Jan 2018 15:25:15 -0500 Date: Mon, 22 Jan 2018 15:25:13 -0500 (EST) Message-Id: <20180122.152513.1108868799788445512.davem@davemloft.net> To: dudenis2000@yahoo.ca Cc: khc@pm.waw.pl, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Carrier detect ok, don't turn off negotiation From: David Miller In-Reply-To: <751079597.1884905.1516121905374@mail.yahoo.com> References: <751079597.1884905.1516121905374.ref@mail.yahoo.com> <751079597.1884905.1516121905374@mail.yahoo.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Denis Du Date: Tue, 16 Jan 2018 16:58:25 +0000 (UTC) > From b5902a4dfc709b62b704997ab64f31c9ef69a6db Mon Sep 17 00:00:00 2001 > From: Denis Du > Date: Mon, 15 Jan 2018 17:26:06 -0500 > Subject: [PATCH] netdev: carrier detect ok, don't turn off negotiation > > Sometimes when physical lines have a just good noise to make the protocol > handshaking fail, but the carrier detect still good. Then after remove of > the noise, nobody will trigger this protocol to be start again to cause > the link to never come back. The fix is when the carrier is still on, not > terminate the protocol handshaking. > > Signed-off-by: Denis Du The timer is supposed to restart the protocol again, that's how this whole thing is designed to work. I think you are making changes to the symptom rather than the true cause of the problems you are seeing. Sorry, I will not apply this until the exact issue is better understood. Thank you.