From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751195AbeAVUn0 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 Jan 2018 15:43:26 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:40644 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750878AbeAVUnX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Jan 2018 15:43:23 -0500
Date: Mon, 22 Jan 2018 15:43:18 -0500 (EST)
Message-Id: <20180122.154318.784941022568373440.davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, dsahern@gmail.com, jiri@resnulli.us,
        cphealy@gmail.com, andrew@lunn.ch, jakub.kicinski@netronome.com,
        decot@googlers.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
        daniel@iogearbox.net, nikolay@cumulusnetworks.com, ast@fb.com,
        roopa@cumulusnetworks.com, vyasevich@gmail.com, jonas@southpole.se,
        maheshb@google.com, stephen@networkplumber.org, ishkamiel@gmail.com,
        fw@strlen.de, arvind.yadav.cs@gmail.com, avagin@openvz.org,
        mingo@kernel.org, lucien.xin@gmail.com, mschiffer@universe-factory.net,
        jbenc@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: core: Expose number of link up/down
 transitions
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180118175921.17645-1-f.fainelli@gmail.com>
References: <20180118175921.17645-1-f.fainelli@gmail.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 18 Jan 2018 09:59:13 -0800

> From: David Decotigny <decot@googlers.com>
> 
> Expose the number of times the link has been going UP or DOWN, and
> update the "carrier_changes" counter to be the sum of these two events.
> While at it, also update the sysfs-class-net documentation to cover:
> carrier_changes (3.15), carrier_up_count (4.16) and carrier_down_count
> (4.16)
> 
> Signed-off-by: David Decotigny <decot@googlers.com>
> [Florian:
> * rebase
> * add documentation
> * merge carrier_changes with up/down counters]
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes in v2:
> - fixed sysfs attributes to use <iface>
> - renamed count_link_{up,down} to carrier_{up,down}_count to match
>   existing carrier_changes semantics

Like David Ahern I am strongly against the proliferation of sysfs files
attached to network devices and the per-netdevice costs associated with
that.

However, dealing with that is a longer term issue that nobody has a clear
plan for.  Therefore I cannot reject this change on that basis alone.

The information is useful, so applied, thanks.