From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbeAVIpt (ORCPT ); Mon, 22 Jan 2018 03:45:49 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:43091 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbeAVIpr (ORCPT ); Mon, 22 Jan 2018 03:45:47 -0500 Date: Mon, 22 Jan 2018 09:45:45 +0100 From: Maxime Ripard To: Giulio Benetti Cc: airlied@linux.ie, wens@csie.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE Message-ID: <20180122084545.kdhrpr5mkqnvkj2o@flea.lan> References: <1516474221-114596-1-git-send-email-giulio.benetti@micronovasrl.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pl34ceidkot3qqy7" Content-Disposition: inline In-Reply-To: <1516474221-114596-1-git-send-email-giulio.benetti@micronovasrl.com> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pl34ceidkot3qqy7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, Jan 20, 2018 at 07:50:20PM +0100, Giulio Benetti wrote: > Can't set dclk polarity on sun4i. >=20 > Handle both positive and negative dclk polarity, > according to bus_flags. It's not really that we can't set it, it's that it's been ignored. > Signed-off-by: Giulio Benetti > --- > drivers/gpu/drm/sun4i/sun4i_tcon.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/s= un4i_tcon.c > index f4284b5..6121210 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c > +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > =20 > #include > =20 > @@ -173,6 +174,9 @@ static void sun4i_tcon0_mode_set_common(struct sun4i_= tcon *tcon, > static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon, > const struct drm_display_mode *mode) > { > + struct drm_panel *panel =3D tcon->panel; > + struct drm_connector *connector =3D panel->connector; > + struct drm_display_info display_info =3D connector->display_info; > unsigned int bp, hsync, vsync; > u8 clk_delay; > u32 val =3D 0; > @@ -226,8 +230,13 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tc= on *tcon, > if (!(mode->flags & DRM_MODE_FLAG_PVSYNC)) > val |=3D SUN4I_TCON0_IO_POL_VSYNC_POSITIVE; > =20 > + if(display_info.bus_flags & DRM_BUS_FLAG_PIXDATA_POSEDGE) > + val |=3D SUN4I_TCON0_IO_POL_DCLK_PHASE(1); > + Checkpatch here returns: ERROR: space required before the open parenthesis '(' And, where did you find that info? How does it interact with the set_phase callback of the dotclock driver? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --pl34ceidkot3qqy7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlplpLgACgkQ0rTAlCFN r3Qcsw/4hx0bf1Xj1ysHYQPt3A/PwRCl+o9AquZhmIFlawWBl5EB62tSa1RCHYF2 t7Og7oK8milBBnkZcv+hfFaL3xYd5bdep2cPmK/1N/z02sp4I+fM3fNlBgtQemk3 ctESdDgUpAb+LhV27+2UEdf/j81qf7Rycyzo0tSGuEPGBTyPGxlVQdP3bO/HaVGr LOVMOlSUAZGy9+Jg5vFjcQKnDE+Es+9Eo7KjF7LDwAGDHY0WM4xvzP/bXHyogVok YcyB6lkBHpFDZEd8HiDVWfB2UizrdlhUONqiLgdYmTG4pcKoqPOE88Kg6XhnCI53 xTih4jMRL3WeLeJ7C+nsggRK/bmG8weTV7sHZ9rl8+6jKuIfkUwObaoerSGYP2yU ZCUaBQTBkqPqucMo3GUx/Vy0ZI+ZeeKM2ouxr60ENddyW/iezCpEJxKi7eADRQmk yd3DZBhm6a13JHrTvba23nG6iHOFC96Zf7svjq6fhoAWbkdwgGTlYDVNpqXotbrV T4+cxdT7QEve1475LkZpXWLs6oKuwg3gvA9hJOYmuB5dBRFFgund1ZsngyrpwnCk tjQJ9wYZkDi60T00mxXJotfgVIMI6BtnIhzDfleolHcVdi1/Zav5nSMuMOBRdd8G OHHMvhzyPtSIGRfTRuynH45/dWBLfXr4dddd+PP66Ta52zOQ0g== =L/Ks -----END PGP SIGNATURE----- --pl34ceidkot3qqy7--