From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751244AbeAVPuO (ORCPT ); Mon, 22 Jan 2018 10:50:14 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:41155 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbeAVPuM (ORCPT ); Mon, 22 Jan 2018 10:50:12 -0500 X-Google-Smtp-Source: AH8x22540Mya7IiIcmfcvzTMM5vUgHeCKbOThQ9zju3qMpre+I8kL1dlbDRCsp4MT13q218UjpFtLw== Date: Mon, 22 Jan 2018 15:50:09 +0000 From: Lee Jones To: SF Markus Elfring Cc: linux-omap@vger.kernel.org, Tony Lindgren , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/3] mfd/omap-usb-tll: Improve a size determination in usbtll_omap_probe() Message-ID: <20180122155009.je377sf325rva7y4@dell> References: <49a9d036-ab90-4342-90a8-db63e027017e@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <49a9d036-ab90-4342-90a8-db63e027017e@users.sourceforge.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Jan 2018, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 15 Jan 2018 13:43:53 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/mfd/omap-usb-tll.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c > index 7945efa0152e..c8b4ad40910a 100644 > --- a/drivers/mfd/omap-usb-tll.c > +++ b/drivers/mfd/omap-usb-tll.c > @@ -220,8 +220,7 @@ static int usbtll_omap_probe(struct platform_device *pdev) > int i, ver; > > dev_dbg(dev, "starting TI HSUSB TLL Controller\n"); > - Keep the space between. > - tll = devm_kzalloc(dev, sizeof(struct usbtll_omap), GFP_KERNEL); > + tll = devm_kzalloc(dev, sizeof(*tll), GFP_KERNEL); > if (!tll) > return -ENOMEM; > -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog