From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751200AbeAVPvE (ORCPT ); Mon, 22 Jan 2018 10:51:04 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38111 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbeAVPvB (ORCPT ); Mon, 22 Jan 2018 10:51:01 -0500 X-Google-Smtp-Source: AH8x224HwX+qHvcvZmLn6HOssQnscwDObBnSXJN1lhAVU3x8jvi4pWdHdc1/EDSch9+P4b9MS5NDdA== Date: Mon, 22 Jan 2018 15:50:57 +0000 From: Lee Jones To: SF Markus Elfring Cc: linux-omap@vger.kernel.org, Tony Lindgren , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3] mfd/omap-usb-tll: Return an error code only as a constant in usbtll_omap_probe() Message-ID: <20180122155057.7eiu53l6xjls6uga@dell> References: <367e77d8-3a65-2c12-5e79-75a626b65f41@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <367e77d8-3a65-2c12-5e79-75a626b65f41@users.sourceforge.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Jan 2018, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 15 Jan 2018 14:00:45 +0100 > > * Return an error code without storing it in an intermediate variable. > > * Delete the label "err_clk_alloc" and local variable "ret" > which became unnecessary with this refactoring. > > Signed-off-by: Markus Elfring > --- > drivers/mfd/omap-usb-tll.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) Applied, thanks. -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog