From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751189AbeAVXQx (ORCPT ); Mon, 22 Jan 2018 18:16:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:42314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbeAVXQw (ORCPT ); Mon, 22 Jan 2018 18:16:52 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F98A21783 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 22 Jan 2018 18:16:49 -0500 From: Steven Rostedt To: Nikolay Borisov Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] ftrace: Fix depth filtering when func_stack is enabled. Message-ID: <20180122181649.7486d421@gandalf.local.home> In-Reply-To: <1516629004-16658-1-git-send-email-nborisov@suse.com> References: <1516629004-16658-1-git-send-email-nborisov@suse.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jan 2018 15:50:04 +0200 Nikolay Borisov wrote: > diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c > index 27f7ad12c4b1..b721f1f3f3c0 100644 > --- a/kernel/trace/trace_functions.c > +++ b/kernel/trace/trace_functions.c > @@ -181,14 +181,11 @@ function_stack_trace_call(unsigned long ip, unsigned long parent_ip, > pc = preempt_count(); > trace_function(tr, ip, parent_ip, flags, pc); > /* > - * skip over 5 funcs: > - * __ftrace_trace_stack, > - * __trace_stack, > + * skip over 2 funcs: > * function_stack_trace_call > - * ftrace_list_func Thanks, but this breaks when you are not using ORC unwinder. > * ftrace_call > */ > - __trace_stack(tr, flags, 5, pc); > + __trace_stack(tr, flags, 2, pc); > } > > atomic_dec(&data->disabled); There's a bit of ORC unwinder breakage that I'm still dealing with. I also have patches to handle the differences between ORC and FP, in the __trace_stack() usages. I'm hoping to have this all fixed by tomorrow, as I'll be traveling after that. Thanks! -- Steve