From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751851AbeAVS6I (ORCPT ); Mon, 22 Jan 2018 13:58:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47566 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbeAVS6G (ORCPT ); Mon, 22 Jan 2018 13:58:06 -0500 From: jglisse@redhat.com To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Ralph Campbell , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= Subject: [PATCH] mm/hmm: fix uninitialized use of 'entry' in hmm_vma_walk_pmd() Date: Mon, 22 Jan 2018 13:57:59 -0500 Message-Id: <20180122185759.26286-1-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ralph Campbell The variable 'entry' is used before being initialized in hmm_vma_walk_pmd() Signed-off-by: Ralph Campbell Signed-off-by: Jérôme Glisse --- mm/hmm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index ea19742a5d60..979211c7ccc8 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -418,7 +418,7 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, } if (!pte_present(pte)) { - swp_entry_t entry; + swp_entry_t entry = pte_to_swp_entry(pte); if (!non_swap_entry(entry)) { if (hmm_vma_walk->fault) @@ -426,8 +426,6 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, continue; } - entry = pte_to_swp_entry(pte); - /* * This is a special swap entry, ignore migration, use * device and report anything else as error. -- 2.14.3