From: Bjorn Helgaas <helgaas@kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jailhouse-dev@googlegroups.com
Subject: Re: [PATCH v2 12/12] x86/jailhouse: Initialize PCI support
Date: Mon, 22 Jan 2018 16:26:10 -0600 [thread overview]
Message-ID: <20180122222610.GA197931@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <e8d19494b96b68a749bcac514795d864ad9c28c3.1511770314.git.jan.kiszka@siemens.com>
On Mon, Nov 27, 2017 at 09:11:54AM +0100, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> With this change, PCI devices can be detected and used inside a non-root
> cell.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> arch/x86/kernel/jailhouse.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/x86/kernel/jailhouse.c b/arch/x86/kernel/jailhouse.c
> index 8ff21e1534de..70b857d4b1f5 100644
> --- a/arch/x86/kernel/jailhouse.c
> +++ b/arch/x86/kernel/jailhouse.c
> @@ -18,6 +18,7 @@
> #include <asm/hypervisor.h>
> #include <asm/i8259.h>
> #include <asm/irqdomain.h>
> +#include <asm/pci_x86.h>
> #include <asm/reboot.h>
> #include <asm/setup.h>
>
> @@ -108,6 +109,19 @@ static void jailhouse_no_restart(void)
> machine_halt();
> }
>
> +static int __init jailhouse_pci_arch_init(void)
> +{
> + pci_direct_init(1);
> +
> + /*
> + * There are no bridges on the virtual PCI root bus under Jailhouse,
> + * thus no other way to discover all devices than a full scan.
> + */
> + pcibios_last_bus = 0xff;
Can you help me understand the comment here? If the virtual root bus
is bus 00, are you saying the guest might see devices on bus 00 and
bus 01, with no bus 00 bridge that leads to bus 01?
I suspect you mean something different because you say elsewhere that
ARM "just works" because DT provides more configurability. But even
on ARM with DT, we probe the root bus and only probe other buses when
we find bridges leading to them.
So I suspect the purpose of this may be to discover devices that are
below host bridges not exposed by ACPI. For example, my BIOS may
expose one host bridge:
ACPI: PCI Root Bridge [PCI0] (domain 0000 [bus 00-7e])
but the chipset may implement devices on bus 7f even though the BIOS
did not advertise the host bridge leading to that bus. This is a case
of a missing host bridge, not a missing bridge on the root bus.
Can you show an example "lspci -v" output to make this concrete?
> + return 0;
> +}
> +
> static void __init jailhouse_init_platform(void)
> {
> u64 pa_data = boot_params.hdr.setup_data;
> @@ -117,6 +131,7 @@ static void __init jailhouse_init_platform(void)
> x86_init.irqs.pre_vector_init = x86_init_noop;
> x86_init.timers.timer_init = jailhouse_timer_init;
> x86_init.mpparse.get_smp_config = jailhouse_get_smp_config;
> + x86_init.pci.arch_init = jailhouse_pci_arch_init;
>
> x86_platform.calibrate_cpu = jailhouse_get_tsc;
> x86_platform.calibrate_tsc = jailhouse_get_tsc;
> @@ -159,6 +174,8 @@ static void __init jailhouse_init_platform(void)
>
> precalibrated_tsc_khz = setup_data.tsc_khz;
>
> + pci_probe = 0;
> +
> /*
> * Avoid that the kernel complains about missing ACPI tables - there
> * are none in a non-root cell.
> --
> 2.12.3
>
next prev parent reply other threads:[~2018-01-22 22:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 8:11 [PATCH v2 00/12] x86: Add support for running as secondary Jailhouse guest Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 01/12] x86/apic: Install an empty physflat_init_apic_ldr Jan Kiszka
2018-01-14 20:34 ` [tip:x86/platform] " tip-bot for Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 02/12] x86: Control warm reset setup via legacy feature flag Jan Kiszka
2018-01-14 20:34 ` [tip:x86/platform] x86/platform: " tip-bot for Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 03/12] x86: Introduce and use MP IRQ trigger and polarity defines Jan Kiszka
2018-01-14 20:34 ` [tip:x86/platform] " tip-bot for Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 04/12] x86/jailhouse: Add infrastructure for running in non-root cell Jan Kiszka
2018-01-14 20:35 ` [tip:x86/platform] " tip-bot for Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 05/12] x86/jailhouse: Enable APIC and SMP support Jan Kiszka
2018-01-14 20:36 ` [tip:x86/platform] " tip-bot for Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 06/12] x86/jailhouse: Enable PMTIMER Jan Kiszka
2018-01-14 20:36 ` [tip:x86/platform] " tip-bot for Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 07/12] x86/jailhouse: Set up timekeeping Jan Kiszka
2018-01-14 20:37 ` [tip:x86/platform] " tip-bot for Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 08/12] x86/jailhouse: Avoid access of unsupported platform resources Jan Kiszka
2018-01-14 20:37 ` [tip:x86/platform] " tip-bot for Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 09/12] x86/jailhouse: Silence ACPI warning Jan Kiszka
2018-01-14 20:37 ` [tip:x86/platform] " tip-bot for Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 10/12] x86/jailhouse: Halt instead of failing to restart Jan Kiszka
2018-01-14 20:38 ` [tip:x86/platform] " tip-bot for Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 11/12] x86/jailhouse: Wire up IOAPIC for legacy UART ports Jan Kiszka
2018-01-14 20:38 ` [tip:x86/platform] " tip-bot for Jan Kiszka
2017-11-27 8:11 ` [PATCH v2 12/12] x86/jailhouse: Initialize PCI support Jan Kiszka
2018-01-14 20:39 ` [tip:x86/platform] " tip-bot for Jan Kiszka
2018-01-22 22:26 ` Bjorn Helgaas [this message]
2018-01-23 7:49 ` [PATCH v2 12/12] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122222610.GA197931@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=jailhouse-dev@googlegroups.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®