From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751228AbeAVXET (ORCPT ); Mon, 22 Jan 2018 18:04:19 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:37212 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbeAVXEQ (ORCPT ); Mon, 22 Jan 2018 18:04:16 -0500 X-Google-Smtp-Source: AH8x226Z3ZGLcfVlgWVCsx77oK3aEvciGtYluPo9KGYs54zkDZNzjUL71uWDJ9uY7tKHwYINzd+6bA== From: Florian Fainelli To: bcm-kernel-feedback-list@broadcom.com, Mathieu Malaterre , Rob Herring Cc: Mark Rutland , Russell King , Ray Jui , Scott Branden , Jon Mason , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/25] arm: bcm: dts: Remove leading 0x and 0s from bindings notation Date: Mon, 22 Jan 2018 15:04:09 -0800 Message-Id: <20180122230410.8712-1-f.fainelli@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171215124628.30029-1-malat@debian.org> References: <20171215124628.30029-1-malat@debian.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Dec 2017 13:46:28 +0100, Mathieu Malaterre wrote: > Improve the DTS files by removing all the leading "0x" and zeros to fix the > following dtc warnings: > > Warning (unit_address_format): Node /XXX unit name should not have leading "0x" > > and > > Warning (unit_address_format): Node /XXX unit name should not have leading 0s > > Converted using the following command: > > find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C > > For simplicity, two sed expressions were used to solve each warnings separately. > > To make the regex expression more robust a few other issues were resolved, > namely setting unit-address to lower case, and adding a whitespace before the > the opening curly brace: > > https://elinux.org/Device_Tree_Linux#Linux_conventions > > This will solve as a side effect warning: > > Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format error, expected "" > > This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") > > Reported-by: David Daney > Suggested-by: Rob Herring > Signed-off-by: Mathieu Malaterre > --- Applied to devicetree/fixes, thanks! -- Florian