From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752143AbeAWPCV (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 Jan 2018 10:02:21 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:53642 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751865AbeAWPCT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 Jan 2018 10:02:19 -0500
Date: Tue, 23 Jan 2018 10:02:17 -0500 (EST)
Message-Id: <20180123.100217.2156136452621715003.davem@davemloft.net>
To: garsilva@embeddedor.com
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180122222213.GA14829@embeddedor.com>
References: <20180122222213.GA14829@embeddedor.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Mon, 22 Jan 2018 16:22:13 -0600

> Assign true or false to boolean variables instead of an integer value.
> 
> This issue was detected with the help of Coccinelle.
> 
> Fixes: 1cb3fe513f62 ("ndisc: Break down ndisc_build_skb() and build message directly.")
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Please don't use the word "fix".

'0' is the same as 'false', it's just that the latter is more
consistent type wise.

You aren't fixing any bugs with these changes at all.