From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751653AbeAWQR2 (ORCPT ); Tue, 23 Jan 2018 11:17:28 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:55066 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbeAWQR1 (ORCPT ); Tue, 23 Jan 2018 11:17:27 -0500 Date: Tue, 23 Jan 2018 11:17:25 -0500 (EST) Message-Id: <20180123.111725.1910125353313770902.davem@davemloft.net> To: colin.king@canonical.com Cc: rasesh.mody@cavium.com, harish.patil@cavium.com, Dept-GELinuxNICDev@cavium.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bnx2: remove redundant initializations of pointers txr and rxr From: David Miller In-Reply-To: <20180123094408.30366-1-colin.king@canonical.com> References: <20180123094408.30366-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 23 Jan 2018 09:44:08 +0000 > From: Colin Ian King > > Pointers txr and rxr are being initialized and a few statements later > are being assigned new values without the original values ever being > read. The initialized values are therefore redundant and can be > removed. > > Cleans up clang warnings: > drivers/net/ethernet/broadcom/bnx2.c:5821:28: warning: Value stored to > 'txr' during its initialization is never read > drivers/net/ethernet/broadcom/bnx2.c:5822:28: warning: Value stored to > 'rxr' during its initialization is never read > > Signed-off-by: Colin Ian King Applied, thanks Colin.