From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751301AbeAWJvH (ORCPT ); Tue, 23 Jan 2018 04:51:07 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:39725 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbeAWJvE (ORCPT ); Tue, 23 Jan 2018 04:51:04 -0500 X-Google-Smtp-Source: AH8x2245i9Io0e7SbTkjdl1Z+nLjHhuur5PR7kO3sS5LHIkw1MWvdo4nVt4btl+a5jMPvJnJBY+u5Q== Date: Tue, 23 Jan 2018 09:50:59 +0000 From: Lee Jones To: SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH 2/2] mfd: smsc-ece1099: Improve a size determination in smsc_i2c_probe() Message-ID: <20180123095059.bushkfuww6nyjvlo@dell> References: <978023d9-01f2-3a16-5eba-e06b8359cfc0@users.sourceforge.net> <721383c6-7d82-7911-989d-fb230038a52b@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <721383c6-7d82-7911-989d-fb230038a52b@users.sourceforge.net> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Jan 2018, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 16 Jan 2018 08:58:26 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/mfd/smsc-ece1099.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c > index b9d96651cc0d..6681205dd2c0 100644 > --- a/drivers/mfd/smsc-ece1099.c > +++ b/drivers/mfd/smsc-ece1099.c > @@ -33,12 +33,10 @@ static const struct regmap_config smsc_regmap_config = { > static int smsc_i2c_probe(struct i2c_client *i2c, > const struct i2c_device_id *id) > { > - struct smsc *smsc; > int devid, rev, venid_l, venid_h; > int ret; > + struct smsc *smsc = devm_kzalloc(&i2c->dev, sizeof(*smsc), GFP_KERNEL); Please keep these separate. > - smsc = devm_kzalloc(&i2c->dev, sizeof(struct smsc), > - GFP_KERNEL); > if (!smsc) > return -ENOMEM; > -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog