From: Michael Grzeschik <m.grzeschik@pengutronix.de>
To: a.zummo@towertech.it, alexandre.belloni@free-electrons.com
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux@roeck-us.net,
jdelvare@suse.com, kernel@pengutronix.de,
Denis.Osterland@diehl.com
Subject: [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits
Date: Tue, 23 Jan 2018 13:17:58 +0100 [thread overview]
Message-ID: <20180123121801.4214-2-m.grzeschik@pengutronix.de> (raw)
In-Reply-To: <20180123121801.4214-1-m.grzeschik@pengutronix.de>
From: Denis Osterland <Denis.Osterland@diehl.com>
After successful
sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN);
sr will be 0.
As a result
sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR,
sr & ~ISL1208_REG_SR_WRTC);
is equal to
sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR, 0);
which clears all flags in SR.
Add an additional read of SR, to have value of SR in sr again.
Signed-off-by: Denis Osterland <Denis.Osterland@diehl.com>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
drivers/rtc/rtc-isl1208.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index 8dd299c6a1f33..c8b4953482296 100644
--- a/drivers/rtc/rtc-isl1208.c
+++ b/drivers/rtc/rtc-isl1208.c
@@ -459,6 +459,11 @@ isl1208_i2c_set_time(struct i2c_client *client, struct rtc_time const *tm)
}
/* clear WRTC again */
+ sr = isl1208_i2c_get_sr(client);
+ if (sr < 0) {
+ dev_err(&client->dev, "%s: reading SR failed\n", __func__);
+ return sr;
+ }
sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR,
sr & ~ISL1208_REG_SR_WRTC);
if (sr < 0) {
--
2.11.0
next prev parent reply other threads:[~2018-01-23 12:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 12:17 [PATCH 0/4] rtc: isl1208: fixes, documentation and isl1219 support Michael Grzeschik
2018-01-23 12:17 ` Michael Grzeschik [this message]
2018-02-14 20:26 ` [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits Alexandre Belloni
2018-02-15 7:27 ` Denis OSTERLAND
2018-02-15 8:30 ` Alexandre Belloni
2018-01-23 12:17 ` [PATCH 2/4] rtc: isl1208: Add device tree binding documentation Michael Grzeschik
2018-01-29 23:34 ` Rob Herring
2018-01-30 10:06 ` Alexandre Belloni
2018-01-23 12:18 ` [PATCH 3/4] rtc: isl1208: enable interrupt after context preparation Michael Grzeschik
2018-01-30 10:34 ` Alexandre Belloni
2018-01-23 12:18 ` [PATCH 4/4] rtc: isl1208: add support for isl1219 with hwmon for tamper detection Michael Grzeschik
2018-01-23 18:22 ` Guenter Roeck
2018-01-24 9:03 ` Michael Grzeschik
2018-01-24 12:10 ` Michael Grzeschik
2018-01-29 21:59 ` Guenter Roeck
2018-01-30 10:27 ` Alexandre Belloni
2018-01-30 11:40 ` Denis OSTERLAND
2018-01-30 14:15 ` Guenter Roeck
2018-01-31 10:54 ` Alexandre Belloni
2018-01-29 23:41 ` Rob Herring
2018-01-30 8:56 ` Denis OSTERLAND
2018-01-30 14:41 ` Rob Herring
2018-01-30 14:44 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123121801.4214-2-m.grzeschik@pengutronix.de \
--to=m.grzeschik@pengutronix.de \
--cc=Denis.Osterland@diehl.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®