From: Kim Phillips <kim.phillips@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fixing uninitialised variable
Date: Tue, 23 Jan 2018 13:36:25 -0600 [thread overview]
Message-ID: <20180123133625.33c81314ce61bc181d4de03d@arm.com> (raw)
In-Reply-To: <1516659460-31733-1-git-send-email-mathieu.poirier@linaro.org>
On Mon, 22 Jan 2018 15:17:40 -0700
Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
> When working natively on arm64 the compiler gets pesky and complains
FWIW, I've only seen this on ARCH=arm64 builds with gcc versions less
than 5, i.e, 4.8.5.
> that variable 'i' is uninitialised, something that breaks the
> compilation.
It'd be nice to include the full compiler error message, to help users
searching for how to fix the error.
> Here no further checks are needed since variable 'found_spe'
> can only be true if variable 'i' has been initialised as part of the for
> loop.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
Cc'ing me and adding a:
Fixes: ffd3d18c20b8 ("perf tools: Add ARM Statistical Profiling Extensions (SPE) support")
line would also be nice.
Other than those nits:
Acked-by: Kim Phillips <kim.phillips@arm.com>
Thanks!
Kim
prev parent reply other threads:[~2018-01-23 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 22:17 Mathieu Poirier
2018-01-23 19:36 ` Kim Phillips [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123133625.33c81314ce61bc181d4de03d@arm.com \
--to=kim.phillips@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®