From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709AbeAWQbh (ORCPT ); Tue, 23 Jan 2018 11:31:37 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:44161 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbeAWQbf (ORCPT ); Tue, 23 Jan 2018 11:31:35 -0500 X-Google-Smtp-Source: AH8x227QHS128AUQr+9BUM3Mfr2cUg7GkTyfh+22W04p9CEmDWXg8oPpkBGpbezPAxpfUMDq/DP1iw== Date: Tue, 23 Jan 2018 16:31:30 +0000 From: Lee Jones To: SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, LKML , Lars =?iso-8859-1?Q?P=F6schel?= , Samuel Ortiz Subject: Re: mfd: Patch management? Message-ID: <20180123163130.h6ygmzig7syafxbh@dell> References: <9c50fe6a-21cc-e49d-1b10-5d2457ed4e2a@users.sourceforge.net> <20180123125851.ysypf7375sjlgsc6@dell> <20180123130130.powyttapsx3djawx@dell> <20180123151419.prwq62c7gpsnpbx3@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Jan 2018, SF Markus Elfring wrote: > > My preferred mailer (Mutt) re-orders replied-to mails by putting them > > to the top of my Inbox. At which point I have to re-navigate down to > > the next patch to review. > > How much does this tool influence the amount of update suggestions > which you could handle easily and safely? In the 5 years I've been doing this, this is the first time someone has submitted in such a way as to cause an issue. > > This is fine for most submissions, but you have fired ~30, > > mostly individual patches at me. > > This number could be appropriate. I tried to contribute hundreds > of change possibilities for various software components. Moving forward, my advice to you would be to collect grouped patches on a number of topic branches, then send them out in batches, perhaps every couple of weeks. Sending ~30 patches individually, spaced over a few hours/days, is actually not a good system. It is in fact quite inappropriate and a pain to manage. I for one find many (to be fair, very trivial) patches scatter-gunned throughout my inbox to be rather inconvenient. What I should do really is ask you to take all similar (remove error message, don't use sizeof(struct X), remove '== NULL') changes and squash them into single patches. However, I realise that you might want the "upstream creds", so I won't do that -- but not at the expense of my time/effort. The two choices are to squash or to create a set. > > I'd like you to do the following please: > > It will take a while until you might get the next chance to take > another look at these subsequent patches. I'm not in a hurry. -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog