From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932855AbeAXV1m (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 Jan 2018 16:27:42 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:50356 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932474AbeAXV1j (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 Jan 2018 16:27:39 -0500
Date: Wed, 24 Jan 2018 16:27:37 -0500 (EST)
Message-Id: <20180124.162737.1427515957453841771.davem@davemloft.net>
To: Vadim.Lomovtsev@caviumnetworks.com
Cc: sgoutham@cavium.com, rric@kernel.org,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Vadim.Lomovtsev@cavium.com,
        dnelson@redhat.com
Subject: Re: [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC
 module and driver names
From: David Miller <davem@davemloft.net>
In-Reply-To: <1516630407-23161-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com>
References: <1516290789-3585-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com>
        <1516630407-23161-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
Date: Mon, 22 Jan 2018 06:13:27 -0800

> From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
> 
> It was found that ethtool provides unexisting module name while
> it queries the specified network device for associated driver
> information. Then user tries to unload that module by provided
> module name and fails.
> 
> This happens because ethtool reads value of DRV_NAME macro,
> while module name is defined at the driver's Makefile.
> 
> This patch is to correct Cavium CN88xx Thunder NIC driver modules
> names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf' along
> with updating DRV_NAME macro values accordingly.
> 
> Signed-off-by: Dean Nelson <dnelson@redhat.com>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>

Once your driver has been deployed in a real upstream release you
should never change the driver module name.

So if you want to fix things, you'll have to fix them the other
way around, by not changing the module name but changing the
strings that ethtool ends up with instead.

Thank you.