From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932910AbeAXVid (ORCPT ); Wed, 24 Jan 2018 16:38:33 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:50566 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932474AbeAXVic (ORCPT ); Wed, 24 Jan 2018 16:38:32 -0500 Date: Wed, 24 Jan 2018 16:38:30 -0500 (EST) Message-Id: <20180124.163830.2180124252515802160.davem@davemloft.net> To: jasowang@redhat.com Cc: mst@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH net 1/2] vhost: use mutex_lock_nested() in vhost_dev_lock_vqs() From: David Miller In-Reply-To: <1516699646-7321-1-git-send-email-jasowang@redhat.com> References: <1516699646-7321-1-git-send-email-jasowang@redhat.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Wang Date: Tue, 23 Jan 2018 17:27:25 +0800 > We used to call mutex_lock() in vhost_dev_lock_vqs() which tries to > hold mutexes of all virtqueues. This may confuse lockdep to report a > possible deadlock because of trying to hold locks belong to same > class. Switch to use mutex_lock_nested() to avoid false positive. > > Fixes: 6b1e6cc7855b0 ("vhost: new device IOTLB API") > Reported-by: syzbot+dbb7c1161485e61b0241@syzkaller.appspotmail.com > Signed-off-by: Jason Wang Michael, I see you ACK'd this, meaning that you're OK with these two fixes going via my net tree? Thanks.