From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932864AbeAXVz7 (ORCPT ); Wed, 24 Jan 2018 16:55:59 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:50876 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932659AbeAXVz5 (ORCPT ); Wed, 24 Jan 2018 16:55:57 -0500 Date: Wed, 24 Jan 2018 16:55:55 -0500 (EST) Message-Id: <20180124.165555.720252378850390746.davem@davemloft.net> To: mst@redhat.com Cc: jasowang@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH net 1/2] vhost: use mutex_lock_nested() in vhost_dev_lock_vqs() From: David Miller In-Reply-To: <20180124234511-mutt-send-email-mst@kernel.org> References: <1516699646-7321-1-git-send-email-jasowang@redhat.com> <20180124.163830.2180124252515802160.davem@davemloft.net> <20180124234511-mutt-send-email-mst@kernel.org> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Wed, 24 Jan 2018 23:46:19 +0200 > On Wed, Jan 24, 2018 at 04:38:30PM -0500, David Miller wrote: >> From: Jason Wang >> Date: Tue, 23 Jan 2018 17:27:25 +0800 >> >> > We used to call mutex_lock() in vhost_dev_lock_vqs() which tries to >> > hold mutexes of all virtqueues. This may confuse lockdep to report a >> > possible deadlock because of trying to hold locks belong to same >> > class. Switch to use mutex_lock_nested() to avoid false positive. >> > >> > Fixes: 6b1e6cc7855b0 ("vhost: new device IOTLB API") >> > Reported-by: syzbot+dbb7c1161485e61b0241@syzkaller.appspotmail.com >> > Signed-off-by: Jason Wang >> >> Michael, I see you ACK'd this, meaning that you're OK with these two >> fixes going via my net tree? >> >> Thanks. > > Yes - this seems to be what Jason wanted (judging by the net > tag in the subject) and I'm fine with it. > Thanks a lot. Great, not a problem, done.