From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-901460-1516769750-2-8503643522652934993 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516769749; b=cQ3yRpBjCnR7qNYRCjTc6OqIMm3afduSJ74+p9eyS0kP6ir slndByz5vqBQ7Ha7M3Wroswv7+yhh9HOm8AA2rfUpeLGXvOk21uP+KkjF9E95gwT Vphbv8aDjctWvI85fVOiThvJAYVrsW7QNb2RC+mgyydmim/S/lbsUJybre/dQVOy b94YjYHvcsUTmxV8vOYGxRbF3Dr36/4OVyVLm3RbJQAmrYAKjxtAFV3c/UROPMtS I8KYKgf5x2uJ+g78vxRFQ6ZBdO6qtlqWo43/Y8OlGWh4qlwihTxCF3DQadxzIoiS 2fBdw46p9LgEB+lGl+/HH+kCWTM/+6uSp10/S8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1516769749; bh=wrl7bJ hqJsN5z2iGdZDhkfPZN6bsi+TqXrt8hGsv3Io=; b=FXoOq9T+JBpzrkTDh8hGIU +Z0R/5PxdK7E7pwy+xXTn8l4P7RKrBnpDi36E/iDVteEzgZMAzwoHj39JH4PTG8t ZTGvw1wyYW8RzYaCBl5v2w53vpE+NsSeVDTnQL5bkhrbU98xbbbivTdBprj4mRns mUqqh7myVnsieoKyeYoQbMQApGVfdkAgKqI/q+uKb5f1HupXqsy1Mm4Y+uq3HMGF I4x4GfF9aPUPzIeygfX/7s2tZzyuQmWFifY3lQggyWx3rnvrciwCFmr4TmjhU+ck dMre/ChQj8QDWCwfhxmNSdKcx7KveRFS6WzHqp14QQFQ4r0vpQUSSCEzzihcnyBw == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=IzrSAel3 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=IzrSAel3 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932233AbeAXEzQ (ORCPT ); Tue, 23 Jan 2018 23:55:16 -0500 Received: from mail-dm3nam03on0107.outbound.protection.outlook.com ([104.47.41.107]:39081 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932225AbeAXEP0 (ORCPT ); Tue, 23 Jan 2018 23:15:26 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Trond Myklebust , "J . Bruce Fields" , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 058/100] nfsd: Ensure we check stateid validity in the seqid operation checks Thread-Topic: [PATCH AUTOSEL for 4.14 058/100] nfsd: Ensure we check stateid validity in the seqid operation checks Thread-Index: AQHTlMnif5moL7azgEmmY3Yorg5pJA== Date: Wed, 24 Jan 2018 04:14:54 +0000 Message-ID: <20180124041414.32065-58-alexander.levin@microsoft.com> References: <20180124041414.32065-1-alexander.levin@microsoft.com> In-Reply-To: <20180124041414.32065-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1015;7:n8TVDaMNxDjwlcttIKBJ/nZI/YpYi4e3G8Y4ADqFF++mTQgPnVz+0k4aog5cGA2udaRDf1DtZfAt+LrzwD2ip+wHeAJS9vN/JAPwit84uwhquH7KUZ/BmqXN7AZaxheP5cIXk/rehaFf2C3z04kzK3CY+ynp3lDKyQGxODLO5rpzqDQ9ssOZPEF5tnyfjqZFDThQ5zMPvaFNPnfxLKvNW9sZDec1IxeBDfAMnQ4v0+y7ICNlyjiHDCzPKdkJlkpy x-ms-office365-filtering-correlation-id: 0548b07b-74ba-4332-8386-08d562e115db x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020);SRVR:DM5PR2101MB1015; x-ms-traffictypediagnostic: DM5PR2101MB1015: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231046)(2400081)(944501161)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR2101MB1015;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB1015; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(39380400002)(376002)(366004)(39860400002)(346002)(199004)(189003)(478600001)(6666003)(106356001)(6512007)(53936002)(2900100001)(36756003)(102836004)(2950100002)(2501003)(10290500003)(97736004)(14454004)(81166006)(72206003)(8936002)(6486002)(1076002)(10090500001)(6346003)(26005)(54906003)(4326008)(575784001)(76176011)(99286004)(86362001)(3660700001)(105586002)(6116002)(8676002)(68736007)(22452003)(66066001)(25786009)(6506007)(5660300001)(305945005)(59450400001)(7736002)(3280700002)(5250100002)(2906002)(107886003)(86612001)(6436002)(316002)(81156014)(3846002)(110136005)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1015;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: 9qpHdNCxLn0FAiUSzPKcp4buOGH7lXLJoe5HOdLZkGFCQVuK8nFCoAIMWafjglo+kK6I/H2X4/3ySq/5SWWnqg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0548b07b-74ba-4332-8386-08d562e115db X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 04:14:54.1979 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1015 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Trond Myklebust [ Upstream commit 9271d7e509c1bfc0b9a418caec29ec8d1ac38270 ] After taking the stateid st_mutex, we want to know that the stateid still represents valid state before performing any non-idempotent actions. Signed-off-by: Trond Myklebust Signed-off-by: J. Bruce Fields Signed-off-by: Sasha Levin --- fs/nfsd/nfs4state.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 5ec0ca5cbc1e..c927dbc8f490 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -5184,15 +5184,9 @@ static __be32 nfs4_seqid_op_checks(struct nfsd4_comp= ound_state *cstate, stateid_ status =3D nfsd4_check_seqid(cstate, sop, seqid); if (status) return status; - if (stp->st_stid.sc_type =3D=3D NFS4_CLOSED_STID - || stp->st_stid.sc_type =3D=3D NFS4_REVOKED_DELEG_STID) - /* - * "Closed" stateid's exist *only* to return - * nfserr_replay_me from the previous step, and - * revoked delegations are kept only for free_stateid. - */ - return nfserr_bad_stateid; - mutex_lock(&stp->st_mutex); + status =3D nfsd4_lock_ol_stateid(stp); + if (status !=3D nfs_ok) + return status; status =3D check_stateid_generation(stateid, &stp->st_stid.sc_stateid, nf= sd4_has_session(cstate)); if (status =3D=3D nfs_ok) status =3D nfs4_check_fh(current_fh, &stp->st_stid); --=20 2.11.0