From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-874563-1516768990-2-7868051599778899823 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516768989; b=OeCLxDBW2GtNPPYExzeJ/Xh7+Iw8fijYq7UYgF9I30zuKc9 BPXxggU97G4lbHcZiem/zyNjJud4xqOm0/T6N7rq9Fumn3JV86R6bFqusEf5ECWL 67O2ev9zCQ1l0FVkFNDtRKbJJtKEmw3pqWZOrWfy3F5i/BEBfAj7sIjRxDGb5vP3 aGMmjtCAbXWw/v9g3ngpRqtFp9cS+g/M7Kk6G1YH6srLXwNrBQf/wK1fYWOds7qu feVzXrtwfH96BzAFDa3fFO4Ls3XRWhYrA+aOGbOWSsFlsmqdIaSxTfrDJyQCTmbj zOGYhD14+XPjYwb8bruBHjphCg6vjsmsN1EzhyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1516768989; bh=+lZWr3 xRWJMFU7P+U2Y9UqVKbsBBNGTTyin6DUm8ODU=; b=nzEn/a9fIsURru4LXPoaZt ufeSK4Bubw981yvxLbFCnOHkkU0Z4biRFruGwZgwpkKIyGbxb1nvYBcoR2/PyiWK P6gQ7pgSW4Saw4doRTh+UApIcM0iN86eKqOS0kcB4pGWKxt2WyFkakZSSuY3qnpF /OAhBmtGzhNQdr83BnvKO2kauFmL/D/zCz8tMMLlJnR1Wa7KZTCZANqvPqz1UBoR cWVeyiYr/4JKWiiST1PhZFBIcIlF6TSdhai+9ifQBIQU3BJY5yG9HmyyxI1FvUX8 2O3IxIET0aGQ6I1rDg8HCXsWEltlDz+4qpBKJrTqh3DjQjp1YdM68k6W/KoiHrcg == ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=dPX5OG3j x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=dPX5OG3j x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932422AbeAXEmh (ORCPT ); Tue, 23 Jan 2018 23:42:37 -0500 Received: from mail-cys01nam02on0121.outbound.protection.outlook.com ([104.47.37.121]:64896 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932683AbeAXEQx (ORCPT ); Tue, 23 Jan 2018 23:16:53 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Michael Lyle , Jens Axboe , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 12/55] bcache: check return value of register_shrinker Thread-Topic: [PATCH AUTOSEL for 4.9 12/55] bcache: check return value of register_shrinker Thread-Index: AQHTlMn7sc6qIf0+KEKDPdAiD/kNrQ== Date: Wed, 24 Jan 2018 04:15:34 +0000 Message-ID: <20180124041521.32223-12-alexander.levin@microsoft.com> References: <20180124041521.32223-1-alexander.levin@microsoft.com> In-Reply-To: <20180124041521.32223-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1080;6:BU5iv8ht8OBo9xiWRKPwBVPrElZLQCuxdWa3Ch/pRJK+Au3PPlrkEYUPXM9pWnI+Hrjijfn3STycljsHPGpgr6E15pfnSBC4zEMADHKF8AzlH8XUXoidKvmYLzdCe0DPO98cZsLet2w2thXCRQkIKToOzEazOAEz7PpMldMZJq0nDD89uoTfGwQqTqHfWml8rh+kp8Fs3dAJw299JBfbyrvHmmcnAb/SM/eCGjgntHb66AZsBa0Mw2+SnN1QI6iNSLtpsmI5DXmRep/D7O6y79wQidPB0znWSOSv53B4dpFQ70PDQ8pQt6t/+3n+m6mPxvwX7ia0xTr2f7KNkXvHh2jWBaCDnQ0VqNz4n1pXGNNtVegl1ARRN/cTRObTksKV;5:DtNxeFaz0YJwNo0RgelOhGihLGuPUEaSh4eXxYbQoosGV0gTJEd3MD6p+OBhfmBkDoeeUBUpBpzusJNeGvsEurU+q0BgKCOjvpcng4qrz1j7N6BEJtiWHAwZsUeC0usrRDjeFby0T4LCT9J/BGBdc/dB8nIZ+imTZ2zhBZCPZY0=;24:1sqs4RdpBdxzArOManvpRpEafiB87JQHmIQ82vQJIiAqHuf3DKaimY+6wNU5Z13GngjLgQJkQB+jAXl2eL0ldZp09Rd1yR+TpHiXJFhaFeQ=;7:c22KaGOuCIN2Q+pRCAcmhrvRj2MvzXNWY26fly0jpc6sfkw1cyRzaQss0QmDIQ0SNiwBHveaHBGJaV0q/eVKSWkyclWqQRk3C61KgQkvW/cH85Nmzb4vTLRIiJjJ6yQbjv8h8Opo0rZaOuP4eRFgaNQIGRpLLg5eOeSL5Zd5yUVKX3bqrNEVuQtgVG1O2sHoYa7D8wCoQZXgIGft+bKuPhlWGBgAvEdFT9uIDESSAkDDyJeeueGcmX7B/NaTFMch x-ms-office365-filtering-correlation-id: 4515f5c0-a218-444b-7750-08d562e148dd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020);SRVR:DM5PR2101MB1080; x-ms-traffictypediagnostic: DM5PR2101MB1080: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231046)(2400081)(944501161)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR2101MB1080;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB1080; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(396003)(346002)(39860400002)(39380400002)(366004)(189003)(199004)(72206003)(110136005)(316002)(5250100002)(6346003)(2900100001)(54906003)(1076002)(6116002)(3846002)(22452003)(36756003)(53936002)(99286004)(6512007)(68736007)(2501003)(3660700001)(14454004)(3280700002)(86362001)(102836004)(7736002)(5660300001)(305945005)(575784001)(107886003)(6486002)(6506007)(2906002)(81156014)(26005)(25786009)(4326008)(81166006)(105586002)(8936002)(59450400001)(106356001)(478600001)(10290500003)(6436002)(8676002)(2950100002)(86612001)(97736004)(76176011)(6666003)(10090500001)(66066001)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1080;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: w5Wahn5MCATXZ/YMhk73RWH7tdFD1lEV5NiYizIeRQAwtuTqjmUYX7IT4jDxyy6jYI7jo8srxBSFTGG/jIM2dw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4515f5c0-a218-444b-7750-08d562e148dd X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 04:15:34.5065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1080 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Michael Lyle [ Upstream commit 6c4ca1e36cdc1a0a7a84797804b87920ccbebf51 ] register_shrinker is now __must_check, so check it to kill a warning. Caller of bch_btree_cache_alloc in super.c appropriately checks return value so this is fully plumbed through. This V2 fixes checkpatch warnings and improves the commit description, as I was too hasty getting the previous version out. Signed-off-by: Michael Lyle Reviewed-by: Vojtech Pavlik Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/md/bcache/btree.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c index 2efdce07247c..cac297f8170e 100644 --- a/drivers/md/bcache/btree.c +++ b/drivers/md/bcache/btree.c @@ -803,7 +803,10 @@ int bch_btree_cache_alloc(struct cache_set *c) c->shrink.scan_objects =3D bch_mca_scan; c->shrink.seeks =3D 4; c->shrink.batch =3D c->btree_pages * 2; - register_shrinker(&c->shrink); + + if (register_shrinker(&c->shrink)) + pr_warn("bcache: %s: could not register shrinker", + __func__); =20 return 0; } --=20 2.11.0