From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-874563-1516768416-2-3934254401614064636 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516768416; b=ZUE9EOboJjyTA88vIX5RSpovL1HxR51Q5k0FDmPJaGQBy2P C4gJlUcAzPwrsWPgU6MEDJojwmRgPXQHQmMPPypo+IpBDK4BS+RIdukm2TlgXnxQ 8OZ3x7QqImHskalZQhSPRvGCypOWnHOzHssbTLKpOi8Le8+8haYcpWVZXiOm3odI bSLBY+ZQCWYYhwdfb10+NoXtPWBJXXSFA1OIPmFllJrdIFQ9P6QPik+Ek6B1bzUb poRppuPDdM05zrgk/RlDDxHM/Sf6hTWuq1abG2SZbq0eaVf1nUcRyHp0xY3wKo7g Zrcyq5goJ3JcCTElz2eeFqeS0HAXsiw7Qfg7R5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1516768416; bh=jlgvl/ E5YRu28Wx+a4XW5mIP3b57YbhvsCTz5MbOI0k=; b=tgGW0n94CEwpL+4dfpRvr5 Zys5fVbqBjw/ayl46UEBdSHn55eiDaCVF6PymM3zBv//iTO0tR1lDEoe+IykY6UG UG6YmWXXPzpAlgBDbox+PWP8ckKfeY86PKGJkmxO7F5ZMX+JXwCkmVLzZyw8GSZl yHCHcwX/hGsQJissjYxbuaSmO0/GPsVI1RWZJXD5+mjGKzi6AJOSdwhhaZYJVygM Eenzu/cNwyVd8xJq1um9KwjSMBfckjNVBxoyZnZWB7mylJeowCQ7tRPW08ncCLOF H+uWdBuTcpQE5NmD0oqPFz3wCcfLU8Edj13MFoUkxgAzB4vtw2PGvS2UVuRx3F5w == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=duQ84zxW x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=duQ84zxW x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933212AbeAXEdG (ORCPT ); Tue, 23 Jan 2018 23:33:06 -0500 Received: from mail-by2nam03on0132.outbound.protection.outlook.com ([104.47.42.132]:14154 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932897AbeAXETR (ORCPT ); Tue, 23 Jan 2018 23:19:17 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Larry Finger , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 55/55] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID Thread-Topic: [PATCH AUTOSEL for 4.9 55/55] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID Thread-Index: AQHTlMoJoRR2R5/80EK5hynkW83VMw== Date: Wed, 24 Jan 2018 04:15:58 +0000 Message-ID: <20180124041521.32223-55-alexander.levin@microsoft.com> References: <20180124041521.32223-1-alexander.levin@microsoft.com> In-Reply-To: <20180124041521.32223-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1032;6:7JJi9dFqMRMdcQHnf2t6GvDZcTyQCJ4n/z0l8HY12r/F4mLyLG9jmOqbB+3YVB7LEfL8xQQ9NbHUQo0QLt+ZQ/tK9GsC6BLNHJUg8jlBaP/gHc0ILZETcEw5TtwYuAY0kKnFUTbfj/O3RKiVsUZ1eQuofhvDygGJT9Ef7Wo15AtqfLG46hdi7lTKtrqhosRLq3Y02eILJyh9LhpenAZeF6MpGnuidUaTBbsfF7m56WOfDAhQkRsrpcaxo1dEA1bMkNgr7fKJKyi8Oh5zt4Q90eBu000Nw1hX2QxEmggOd3CVG8FLJV+yl5Nva4DlEsyq8DJeCbL0m7UVYoIs10hmmn8bcZoBgXLk7ZfXEoXWdNFyowqDAO4/xFXh7M/QY6TP;5:P6l+zfVS/DItCar9qrQvffB/fY91jddH9n9Re8WctYRroWGUyNgw97yxgz17y6SPyvPCh8iTRSzKe1j7Tvkgti3J1dFBCx6B1gdK/+jDPbtrWhEodu5tWkW1fiDPmkixH92V/g3jXjlbHZssql69dwk7Pmxi/vsHfp3DVHzXvFg=;24:RBZWB7vUoRwn88LkpP7sJBxEFj5KKNHvpq27P9qPODLiJP6hr5Y6E4MCNRAuA8mwuzlp8zr2sX0Q3RkODlDzyAu48HxQE67UuJPGiL8EGjM=;7:PNPWyDLgYvYFI5E9QIif2CRW1vTS1AgoIgktBBv3Lhvgi0iOCZbX2OW+IJDD2W9i5VG2FLIRHt9vcsdNWPvRooMOjUYyDxCPrmauzhgdByqfuUxkb/pnlNUJAajxzpvPxOmnPeKZJ7ZWDbZdvIESgMFcSIGlTd/SxioSVtzDGdcBIjGSs898Ys2KqAf2yraK58ArbO+rlVyg0Yl2zMcmUmYi7B8nFQNyTmn1rbI0rP4iKvdQfGEd3SEGE2isxL9I x-ms-office365-filtering-correlation-id: 33fb312e-64b3-41bd-4bdf-08d562e1a0a0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020);SRVR:DM5PR2101MB1032; x-ms-traffictypediagnostic: DM5PR2101MB1032: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(166708455590820); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231046)(2400081)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123562045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011);SRVR:DM5PR2101MB1032;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB1032; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(396003)(39860400002)(376002)(346002)(39380400002)(189003)(199004)(36756003)(478600001)(6506007)(8676002)(14454004)(6512007)(53936002)(5660300001)(26005)(72206003)(4326008)(25786009)(81156014)(81166006)(8936002)(86362001)(10290500003)(68736007)(2906002)(6346003)(99286004)(6666003)(86612001)(76176011)(6436002)(102836004)(7736002)(2950100002)(966005)(66066001)(1076002)(10090500001)(54906003)(22452003)(316002)(105586002)(6306002)(106356001)(5250100002)(305945005)(2501003)(3846002)(3280700002)(97736004)(2900100001)(6486002)(6116002)(110136005)(3660700001)(107886003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1032;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: XEvlgcitZ0s9mVLQjHSs/49U6TBZKWHmZXpSrPT6TUSqNnIblMktDarXgx55coYawGXMug5nnm42bQxpV4578A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33fb312e-64b3-41bd-4bdf-08d562e1a0a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 04:15:58.7147 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1032 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Larry Finger [ Upstream commit b77992d2df9e47144354d1b25328b180afa33442 ] When not associated with an AP, wifi device drivers should respond to the SIOCGIWESSID ioctl with a zero-length string for the SSID, which is the behavior expected by dhcpcd. Currently, this driver returns an error code (-1) from the ioctl call, which causes dhcpcd to assume that the device is not a wireless interface and therefore it fails to work correctly with it thereafter. This problem was reported and tested at https://github.com/lwfinger/rtl8188eu/issues/234. Signed-off-by: Larry Finger Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8188eu/os_dep/ioctl_linux.c index 4de9dbc93380..c7bf8ab26192 100644 --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c @@ -1397,19 +1397,13 @@ static int rtw_wx_get_essid(struct net_device *dev, if ((check_fwstate(pmlmepriv, _FW_LINKED)) || (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { len =3D pcur_bss->Ssid.SsidLength; - - wrqu->essid.length =3D len; - memcpy(extra, pcur_bss->Ssid.Ssid, len); - - wrqu->essid.flags =3D 1; } else { - ret =3D -1; - goto exit; + len =3D 0; + *extra =3D 0; } - -exit: - + wrqu->essid.length =3D len; + wrqu->essid.flags =3D 1; =20 return ret; } --=20 2.11.0