From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-874563-1516767702-2-15874436110836542442 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516767701; b=kE0LOedbzFAB3/Yk0TExw4seLMOWRxsQ8u6pJQbu0elKG4m NEeYqdoEtec/DHyDrxtXquSknSlc+M6lHQWSrgvPaFmY2V/HPTKrZtI1CqE6xxNg e0ZiHkgEHTaIXLxj3+b2MQbNc2Z1T7UhT4PyXx9L0yuA9Tdg453yX+EGogeEKVgr b9fTRlyGgPlIqXSEU4zoDOi0CcOUOxiZuALhFanqnCoVpOI9vEFeWOmpB3FaOTdU ThR89TeYIWLK+maNrFWVKKCaPFSKvkKzoljnZFCngLBAHbDAmnz3EAq0SgQrwhH1 wR/5H8pJAealZpW65zJ/yny1xD0DhT1Erpc1ONw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1516767701; bh=LEpc9j xbfEUcXZG8IsAyPjHO07q8nBwCZbIjGvAwWa0=; b=OKwKgn9ZpffBCEFIB74P8f Wrizc2LebFZhSqgSBpX6PXLhvjL6vqqR4SWn/D/nWKpooprulcbiMtCHuzEfq7NC eA5FOEUX2M1gr/Lhn39Ob/fej1LmBsiKRCp5xykIS9JmmOv+8FFD1us9B10iQ6sZ Gb8EY1hIYwQWt544t+Tbv51I4pTOFNiQX9axUP2ZwqEjrSft44hwrY3UGyPLyfZB UDllEtTaZ5nzKNY2piPnQPPaZesDPUSZa0qgbpF4z+MDzDlO0IFC3JRLMKQjscTi TYB0BzxnW6url0GatGTCjlHn7Lp8t9e/+umTFlOQynbpLHTbDWJacMlIhqHI9l6A == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=YKzsFH/E x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=YKzsFH/E x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932590AbeAXEVY (ORCPT ); Tue, 23 Jan 2018 23:21:24 -0500 Received: from mail-cys01nam02on0129.outbound.protection.outlook.com ([104.47.37.129]:44357 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932801AbeAXEUK (ORCPT ); Tue, 23 Jan 2018 23:20:10 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: "Gustavo A. R. Silva" , "Martin K . Petersen" , Sasha Levin Subject: [PATCH AUTOSEL for 3.18 13/16] scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg Thread-Topic: [PATCH AUTOSEL for 3.18 13/16] scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg Thread-Index: AQHTlMo/LfUJxhn2m0GuWyz49/dCfg== Date: Wed, 24 Jan 2018 04:17:29 +0000 Message-ID: <20180124041716.32520-13-alexander.levin@microsoft.com> References: <20180124041716.32520-1-alexander.levin@microsoft.com> In-Reply-To: <20180124041716.32520-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0872;7:ddju4VVqCvwwaCF0X22FfkzxdYWwnfPoGNIHYKmdj6v+EiVBcyPyNgZPcXk/SHTvoO0Jf8mgwY1TF3l9j4AsHkECkkQUbIz2a3hh5nALznCIz+45DUCYW7dwsR6LAyyI324EMaFvhY0YHLLWCEmY6zCNoGVsUx57rhh6cPOVw/JqiVeYYFL8wq3E2WTbCGaABrFqmSxI9h71D8nHFJxMVlbPVTeVKlKiwU45GCM5FKj8zG8kHAgOHMRiVYjuiElP x-ms-office365-filtering-correlation-id: 07dc488a-9daa-4dfa-c5a7-08d562e1bf91 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020);SRVR:DM5PR2101MB0872; x-ms-traffictypediagnostic: DM5PR2101MB0872: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231046)(2400081)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011);SRVR:DM5PR2101MB0872;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0872; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39380400002)(396003)(366004)(346002)(376002)(39860400002)(199004)(189003)(5660300001)(106356001)(72206003)(3280700002)(5250100002)(66066001)(3660700001)(105586002)(14454004)(86612001)(478600001)(53936002)(2900100001)(10290500003)(2501003)(6512007)(10090500001)(6436002)(6506007)(36756003)(6116002)(3846002)(575784001)(6486002)(2906002)(22452003)(107886003)(316002)(54906003)(4326008)(110136005)(6346003)(81166006)(25786009)(26005)(2950100002)(6666003)(86362001)(1076002)(8676002)(7736002)(81156014)(99286004)(305945005)(76176011)(68736007)(97736004)(102836004)(8936002)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0872;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: fTlMXl1ftdajz8tKIcJ5Lz8lMwml48Ev4E9Pz/6NvgJZx2+kSPxv6Lp9uxmgruOh303LRf2KWwcRPqCb8Qb7Ag== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07dc488a-9daa-4dfa-c5a7-08d562e1bf91 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 04:17:29.5650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0872 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: "Gustavo A. R. Silva" [ Upstream commit 727535903bea924c4f73abb202c4b3e85fff0ca4 ] _vreg_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after _vreg_ has been null checked. This issue was detected with the help of Coccinelle. Fixes: aa4976130934 ("ufs: Add regulator enable support") Signed-off-by: Gustavo A. R. Silva Reviewed-by: Subhash Jadavani Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/ufs/ufshcd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 605ca60e8a10..64ee59685aac 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -4287,12 +4287,15 @@ static int ufshcd_config_vreg(struct device *dev, struct ufs_vreg *vreg, bool on) { int ret =3D 0; - struct regulator *reg =3D vreg->reg; - const char *name =3D vreg->name; + struct regulator *reg; + const char *name; int min_uV, uA_load; =20 BUG_ON(!vreg); =20 + reg =3D vreg->reg; + name =3D vreg->name; + if (regulator_count_voltages(reg) > 0) { min_uV =3D on ? vreg->min_uV : 0; ret =3D regulator_set_voltage(reg, min_uV, vreg->max_uV); --=20 2.11.0