From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-858731-1516767682-2-11803350772454539863 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516767682; b=w5NP9hS2IXguKTcftvgS75p6AlZQw3IWCn52XzrTt9oMMPu NOEtZXiYZWZZX71OJIKiRUZ6y7/lZ+DF0OhD4fuZaZ5SslCzdQ7phq/vFc7QraCP sNX5GvffvT4FuauiUx9W2aycZTyXL2CRJUBCuh0v17ooC8nGgTvIK5vRhqFDcdRs zSPukVgZXgGFQHZuKjoPXaiRkXB63HgKK1Q+A3CmLFPFzJl4yl8ELHQ9Eo0kor9R 2pyeRL5rHvMRKPeDIK/OtRDjIKwymDm6BfXY8pI0u2aFW1gwdwUeOJ7Q4C6o2umH AZX/0BzqXbqCjljgnzHBldAW+mmeBxnCoPFdpww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1516767682; bh=NxVZhe PiuK4zKuk5ea01yq7c/H0+d0VRwPzMl1bh7YY=; b=H2SIQ3TUYDeBNwxpvMrBdp zh9PcxoDOcT5Kiz21eQT0MJ4ooJQ9oSskQfNAnF1KHJSjba4E0giXtKVCCrrOQma F7FDEc9Kd+OwP0l8FGqs+Py4i9Gd8s2t4aWc01caST8CZDud50WZforyDDAcv1x2 RDJkcIn7mvN5OwNKsMN/DIJHajlA92MvDO5PMPU3RlxCKnFgAKsHaUe7RpE/zJ3u APXi3t+siuR1k4fFJjF3wnVJZScfvROvciBcGmiLunGtNg4j9718+AGJ+L/HJ8VX sB+AMt8rz834Fg5knC/J6/Nhf6ZAeWY6acyprAAJMeN9CNc8wBMXW0FdNP6r6ElA == ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=bnHBd8F4 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=bnHBd8F4 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbeAXEVH (ORCPT ); Tue, 23 Jan 2018 23:21:07 -0500 Received: from mail-cys01nam02on0093.outbound.protection.outlook.com ([104.47.37.93]:46352 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933334AbeAXEUM (ORCPT ); Tue, 23 Jan 2018 23:20:12 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Larry Finger , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL for 3.18 16/16] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID Thread-Topic: [PATCH AUTOSEL for 3.18 16/16] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID Thread-Index: AQHTlMpAx3kIPrjcgUyJWXGP2SJI2w== Date: Wed, 24 Jan 2018 04:17:31 +0000 Message-ID: <20180124041716.32520-16-alexander.levin@microsoft.com> References: <20180124041716.32520-1-alexander.levin@microsoft.com> In-Reply-To: <20180124041716.32520-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0872;6:QlDWe+42xhIJS6oxbSt54WTDZEtRW93mIslHyDKFn3C/K0/bSco5Q57+YxvL2cs/6z7VfEBCyH4H0Uo00RS6EUXRPho8YQJQsw0poAyBB7uA+WW22NOefdcJwApAC7oL+EOCKc+UgZHcnxZ9w4yV+TXkR+fBvlEnulmWTvXDzDwcOaLsfhyV9WwguYKlQUMLh2qpjSfvJGxsIGR6l+ljWK87pmduhQK84JW/dKESf7bDPhQH+VWIemBNaK28H/nl+3qRO4xx2kbNiFEJwjadU/Zc4SAYncTSMirDCcXJEtxx6uwld3PRu+tqob2+gEyow1yzDaozEqZNmmHJ/Sm+YsuFpbnmdEX3GB2C/VqcI4tj0bue7vq3Qo2b0jPVo271;5:n2ausapDUcCpJXj6My++kesTP8qtgLiiQxXJv9PHAs8xXUH/fl7vSBC1YLkmWrY+rHUDIapyuTxw7+eoalvpwHMB50IrFDXjjRKFs9lRx3N449UiXM9bMGKQAGsZ1BONo7ggNNdVsYEP4begTcIfx97FBbEoB+PI8PlSsxU3YSw=;24:2mDOHm3DkSrHVIjsF/GXiI5DiF7SMTu7e57HDKj5vcvlE1A7e3VYSTPTIf/HHJd88I9Fz50oCel4FAZ+sUB5RdG6J2hDFcA9/DfyPSTZvHA=;7:wjvVg0I/Ec3kfTTY2yJWo2wYs9JG0RsdfnCvJeuxNUSVDAvtILLx5zkc0HNFj7P/LAsAF25B0b9L/xkX3ktAPWxDuMMNJ4bJq2bcGUonCYgGdIlD1Wt6Fdw7lFphFz6QuGD5CjLzRVM2gxipjfxtoHPIZTVYXtIlfCl41aRBi/11bsU9YBa0LnJGos5hq7OzIs2OxjXjcm+Y5aNAFaODtbCED9S6MF45UHodgO+i7FTLl1wa+FyiU3rKWNkBS+xw x-ms-office365-filtering-correlation-id: 3d141260-675e-4729-0904-08d562e1c045 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603307)(7193020);SRVR:DM5PR2101MB0872; x-ms-traffictypediagnostic: DM5PR2101MB0872: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(166708455590820); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231046)(2400081)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011);SRVR:DM5PR2101MB0872;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0872; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(39380400002)(396003)(366004)(346002)(376002)(39860400002)(199004)(189003)(5660300001)(106356001)(72206003)(3280700002)(5250100002)(66066001)(3660700001)(105586002)(14454004)(86612001)(478600001)(53936002)(966005)(2900100001)(10290500003)(6306002)(2501003)(6512007)(10090500001)(6436002)(6506007)(36756003)(6116002)(3846002)(6486002)(2906002)(22452003)(107886003)(316002)(54906003)(4326008)(110136005)(6346003)(81166006)(25786009)(26005)(2950100002)(6666003)(86362001)(1076002)(8676002)(7736002)(81156014)(99286004)(305945005)(76176011)(68736007)(97736004)(102836004)(8936002)(22906009)(217873001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0872;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: ImGkLhewticGqz4zFfTjDsxUwwdUvKIyKF75MSsyJY8sAtX1QDWYjNCWqZ2Zv7ykS/my9fPNz39opI9Otlff3w== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d141260-675e-4729-0904-08d562e1c045 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 04:17:31.2561 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0872 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Larry Finger [ Upstream commit b77992d2df9e47144354d1b25328b180afa33442 ] When not associated with an AP, wifi device drivers should respond to the SIOCGIWESSID ioctl with a zero-length string for the SSID, which is the behavior expected by dhcpcd. Currently, this driver returns an error code (-1) from the ioctl call, which causes dhcpcd to assume that the device is not a wireless interface and therefore it fails to work correctly with it thereafter. This problem was reported and tested at https://github.com/lwfinger/rtl8188eu/issues/234. Signed-off-by: Larry Finger Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/stagi= ng/rtl8188eu/os_dep/ioctl_linux.c index d598fec4abbf..0bfb4fe8a86e 100644 --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c @@ -1396,19 +1396,13 @@ static int rtw_wx_get_essid(struct net_device *dev, if ((check_fwstate(pmlmepriv, _FW_LINKED)) || (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { len =3D pcur_bss->Ssid.SsidLength; - - wrqu->essid.length =3D len; - memcpy(extra, pcur_bss->Ssid.Ssid, len); - - wrqu->essid.flags =3D 1; } else { - ret =3D -1; - goto exit; + len =3D 0; + *extra =3D 0; } - -exit: - + wrqu->essid.length =3D len; + wrqu->essid.flags =3D 1; =20 return ret; } --=20 2.11.0