From: Sasha Levin <Alexander.Levin@microsoft.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: Michael Lyle <mlyle@lyle.org>, Jens Axboe <axboe@kernel.dk>,
Sasha Levin <Alexander.Levin@microsoft.com>
Subject: [PATCH AUTOSEL for 3.18 04/16] bcache: check return value of register_shrinker
Date: Wed, 24 Jan 2018 04:17:24 +0000 [thread overview]
Message-ID: <20180124041716.32520-4-alexander.levin@microsoft.com> (raw)
In-Reply-To: <20180124041716.32520-1-alexander.levin@microsoft.com>
From: Michael Lyle <mlyle@lyle.org>
[ Upstream commit 6c4ca1e36cdc1a0a7a84797804b87920ccbebf51 ]
register_shrinker is now __must_check, so check it to kill a warning.
Caller of bch_btree_cache_alloc in super.c appropriately checks return
value so this is fully plumbed through.
This V2 fixes checkpatch warnings and improves the commit description,
as I was too hasty getting the previous version out.
Signed-off-by: Michael Lyle <mlyle@lyle.org>
Reviewed-by: Vojtech Pavlik <vojtech@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
---
drivers/md/bcache/btree.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 43829d9493f7..e53ce5e2a28a 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -808,7 +808,10 @@ int bch_btree_cache_alloc(struct cache_set *c)
c->shrink.scan_objects = bch_mca_scan;
c->shrink.seeks = 4;
c->shrink.batch = c->btree_pages * 2;
- register_shrinker(&c->shrink);
+
+ if (register_shrinker(&c->shrink))
+ pr_warn("bcache: %s: could not register shrinker",
+ __func__);
return 0;
}
--
2.11.0
next prev parent reply other threads:[~2018-01-24 4:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 4:17 [PATCH AUTOSEL for 3.18 01/16] KVM: x86: emulator: Return to user-mode on L1 CPL=0 emulation failure Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 02/16] KVM: x86: Don't re-execute instruction when not passing CR2 value Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 03/16] KVM: X86: Fix operand/address-size during instruction decoding Sasha Levin
2018-01-24 4:17 ` Sasha Levin [this message]
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 06/16] KVM: VMX: Fix rflags cache during vCPU reset Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 05/16] mac80211: fix the update of path metric for RANN frame Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 08/16] nfsd: CLOSE SHOULD return the invalid special stateid for NFSv4.x (x>0) Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 07/16] xen-netfront: remove warning when unloading module Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 10/16] hwmon: (pmbus) Use 64bit math for DIRECT format values Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 09/16] nfsd: check for use of the closed special stateid Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 11/16] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 13/16] scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 12/16] quota: Check for register_shrinker() failure Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 14/16] media: usbtv: add a new usbid Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 15/16] usb: gadget: don't dereference g until after it has been null checked Sasha Levin
2018-01-24 4:17 ` [PATCH AUTOSEL for 3.18 16/16] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124041716.32520-4-alexander.levin@microsoft.com \
--to=alexander.levin@microsoft.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=mlyle@lyle.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome