From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2143865-1516819217-2-10078365520826472884 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Attached: 0004-trace_uprobe-Display-correct-offset-in-uprobe_events.patch X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516819217; b=Ka//dHynu4yS5g5QIL3IZMyBxSpMPeawRQ7hFCjDEnqOCwV 9+Wj4Nz7rHKmghtkqLK2iGUXPTENRYefEXmg7RmMlfXolsnwaDzfofGw7MZaKMTB 78u0jTHu9iLKCTKje4e6HdVzW51ODWpREs88KzniSgd3beuZHCITzatp7auyE228 Dcx0+G9hKlSBW86M3bHlbOZn6hBl3mbdrpd9mgQ/EkjYb5QIzpMMztdsZ2OugSMr OmkiZVkBdeXsSx5Uo8P/oKhRPujsqxDkVSiGxfWL3Hg9ySUhJESofeNRNYyKmqOS S+UdoK2VKJDQyyq59p3lgTtKKaLsaFGRajOCLgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=message-id:date:from:to:cc:subject :references:mime-version:content-type:sender:list-id; s=arctest; t=1516819217; bh=1uKOdVN/SBPXwrbKrsCFaIre1tMQF/QZQvFZhDKpScM=; b= MubF6NIm4V3hgxNB+aAoxzoSuy+Pv7LRqTfPQN6KiQq+BkUNSUxlABeu7lyQiqM5 Nf3lQWf+u4DXBDvWCqy9RYvIGrtM1LVEv2xHetc60iPGV/ldZXGjQ8k1Lve+7ufn 5ByB8Fsmq2khNLKQ+4xrKfRGDEhnD89DLmBNWzOaHjB0JQ6DzlWfvQO9Pk1mJzWb CnDrFao8GK/74EDqZ5qfcDuPaWC/StnQ3jegRtA7Xtzsaa6mdwTvnlMN9rJMd/6x dJGCow0CYVNVTr2H0pqMornIk+U6uYowaWVNrp7W7XSCQdil/oN0YrhMJFAx2yNz ieMbK9vaZMfeDeJdcaF43g== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=goodmis.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=goodmis.org header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=goodmis.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=goodmis.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964934AbeAXSg7 (ORCPT ); Wed, 24 Jan 2018 13:36:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:36122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964963AbeAXSg5 (ORCPT ); Wed, 24 Jan 2018 13:36:57 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 374962178F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Message-Id: <20180124183656.262267596@goodmis.org> User-Agent: quilt/0.63-1 Date: Wed, 24 Jan 2018 13:36:37 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Ingo Molnar , Andrew Morton , stable@vger.kernel.org, Srikar Dronamraju , Ravi Bangoria Subject: [for-next][PATCH 4/6] trace_uprobe: Display correct offset in uprobe_events References: <20180124183633.610217564@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline; filename=0004-trace_uprobe-Display-correct-offset-in-uprobe_events.patch Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Ravi Bangoria Recently, how the pointers being printed with %p has been changed by commit ad67b74d2469 ("printk: hash addresses printed with %p"). This is causing a regression while showing offset in the uprobe_events file. Instead of %p, use %px to display offset. Before patch: # perf probe -vv -x /tmp/a.out main Opening /sys/kernel/debug/tracing//uprobe_events write=1 Writing event: p:probe_a/main /tmp/a.out:0x58c # cat /sys/kernel/debug/tracing/uprobe_events p:probe_a/main /tmp/a.out:0x0000000049a0f352 After patch: # cat /sys/kernel/debug/tracing/uprobe_events p:probe_a/main /tmp/a.out:0x000000000000058c Link: http://lkml.kernel.org/r/20180106054246.15375-1-ravi.bangoria@linux.vnet.ibm.com Cc: stable@vger.kernel.org Fixes: ad67b74d2469 ("printk: hash addresses printed with %p") Acked-by: Srikar Dronamraju Signed-off-by: Ravi Bangoria Signed-off-by: Steven Rostedt (VMware) --- kernel/trace/trace_uprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index 40592e7b3568..268029ae1be6 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c @@ -608,7 +608,7 @@ static int probes_seq_show(struct seq_file *m, void *v) /* Don't print "0x (null)" when offset is 0 */ if (tu->offset) { - seq_printf(m, "0x%p", (void *)tu->offset); + seq_printf(m, "0x%px", (void *)tu->offset); } else { switch (sizeof(void *)) { case 4: -- 2.15.1