mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Thayer <michael.thayer@oracle.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support
Date: Wed, 24 Jan 2018 20:10:07 +0100	[thread overview]
Message-ID: <20180124191008.20296-1-hdegoede@redhat.com> (raw)

Hi All,

As mentioned in the v2 cover letter, now that the vboxguest driver which the
vboxsf (guest shared folder) fs driver depends on is queued for merging into
4.16 in char-misc-next, all the dependencies for the vboxsf are in place.

So now its time to work towards also getting vboxsf merged.

This version addresses (AFAIK) all comments made in response to v2.

Changes in v3:
 -Use text only mount options, instead of a custom data struct
 -Stop caching full path in inode data, if parents gets renamed it will change
 -Fixed negative dentries handling
 -Dropped the force_reread flag for dirs, not sure what it was actually for
  but it is no good, doing a re-read on unlink of a file will lead to
  another file being skipped if the caller has already iterated over the
  entry for the unlinked file.
 -Use file_inode(), file_dentry() and d_inode() helpers
 -Prefix any non object-private symbols with vboxsf_ so as to not pollute
  the global namespace when builtin
 -Add MAINTAINERS entry
 -Misc. cleanups

Changes in v2:
 -Removed various unused wrapper functions
 -Don't use i_private, instead defined alloc_inode and destroy_inode
  methods and use container_of.
 -Drop obsolete comment referencing people to
  http://www.atnf.csiro.au/people/rgooch/linux/vfs.txt
 -move the single symlink op of from lnkops.c to file.c
 -Use SPDX license headers
 -Replace SHFLROOT / SHFLHANDLE defines with normal types
 -Removed unnecessary S_ISREG checks
 -Got rid of bounce_buffer in regops, instead add a "user" flag to 
  vboxsf_read / vboxsf_write, re-using the existing __user address support
  in the vboxguest module
 -Make vboxsf_wrappers return regular linux errno values
 -Use i_size_write to update size on writing
 -Convert doxygen style comments to kerneldoc style comments

Please review.

Regards,

Hans

             reply	other threads:[~2018-01-24 19:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 19:10 Hans de Goede [this message]
2018-01-24 19:10 ` [PATCH v3] " Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180124191008.20296-1-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.thayer@oracle.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®