From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932474AbeAXUnI (ORCPT ); Wed, 24 Jan 2018 15:43:08 -0500 Received: from avasout06.plus.net ([212.159.14.18]:50125 "EHLO avasout06.plus.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932072AbeAXUnG (ORCPT ); Wed, 24 Jan 2018 15:43:06 -0500 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.3 cv=CaYmGojl c=1 sm=1 tr=0 a=o7Djd4SkmPXITDn8qH+ssQ==:117 a=o7Djd4SkmPXITDn8qH+ssQ==:17 a=kj9zAlcOel0A:10 a=RgaUWeydRksA:10 a=FP58Ms26AAAA:8 a=beXlt2xKAAAA:8 a=GdwhSmZmNHaKCFtdu-8A:9 a=CjuIK1q_8ugA:10 a=gcY2M4Ci8LIz02MwfSIM:22 Date: Wed, 24 Jan 2018 20:35:32 +0000 From: Nick Dyer To: SF Markus Elfring Cc: linux-input@vger.kernel.org, Dmitry Torokhov , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Input: atmel_mxt_ts: Delete error messages for a failed memory allocation in two functions Message-ID: <20180124203531.GA5922@lava.h.shmanahar.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CMAE-Envelope: MS4wfEb0tWdlMFajbCEcIRSxgVDjmOmYl42yWRs9NP8xq+JxWjRSJk5smquVGpv9yxjgXAsIUTiFHLKH81fU8Gb3IYMUaD9czjoBgbaN7LmwmfhQmppZv0tB SBV8siOs8iGV2V/F4URKLV1Ob6uHXTF0Xv7SJ+rv6jDNJX6Lu7LAUwFJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 21, 2018 at 10:33:50PM +0100, SF Markus Elfring wrote: > Omit extra messages for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Thanks! Signed-off-by: Nick Dyer > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index 7659bc48f1db..f38711e9c256 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -1507,10 +1507,8 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *cfg) > MXT_INFO_CHECKSUM_SIZE; > config_mem_size = data->mem_size - cfg_start_ofs; > config_mem = kzalloc(config_mem_size, GFP_KERNEL); > - if (!config_mem) { > - dev_err(dev, "Failed to allocate memory\n"); > + if (!config_mem) > return -ENOMEM; > - } > > ret = mxt_prepare_cfg_mem(data, cfg, data_pos, cfg_start_ofs, > config_mem, config_mem_size); > @@ -1612,10 +1610,8 @@ static int mxt_get_object_table(struct mxt_data *data) > > table_size = data->info.object_num * sizeof(struct mxt_object); > object_table = kzalloc(table_size, GFP_KERNEL); > - if (!object_table) { > - dev_err(&data->client->dev, "Failed to allocate memory\n"); > + if (!object_table) > return -ENOMEM; > - } > > error = __mxt_read_reg(client, MXT_OBJECT_START, table_size, > object_table); > @@ -1714,7 +1710,6 @@ static int mxt_get_object_table(struct mxt_data *data) > data->msg_buf = kcalloc(data->max_reportid, > data->T5_msg_size, GFP_KERNEL); > if (!data->msg_buf) { > - dev_err(&client->dev, "Failed to allocate message buffer\n"); > error = -ENOMEM; > goto free_object_table; > } > -- > 2.16.0 >